Changeset 13344 for trunk/src/bp-activity/classes/class-bp-activity-activity.php

Timestamp:

10/25/2022 07:33:13 PM (3 years ago)

Author:

imath

Message:

Improve the activity loop to be able to get items below a max. ID

The $filter parameter of this loop now includes a new $offset_lower
argument making it possible to only retrieve activities having an ID
lower than this argument provided value.

We are using this filter to avoid a possible activity duplicate when
clicking on the "Load More" link.

Closes ​https://github.com/buddypress/buddypress/pull/29
Fixes #4535

File:

• trunk/src/bp-activity/classes/class-bp-activity-activity.php (modified) (2 diffs)

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -1923 +1923 @@
      *     @type int              $offset       Return only those items with an ID greater
      *                                          than the offset value.
+     *     @type int              $offset_lower Return only those items with an ID lower
+     *                                          than the offset value.
      *     @type string           $since        Return only those items that have a
      *                                          date_recorded value greater than a
@@ -1966 +1968 @@
             $sid_sql = absint( $filter_array['offset'] );
             $filter_sql[] = "a.id >= {$sid_sql}";
+        }
+
+        if ( ! empty( $filter_array['offset_lower'] ) ) {
+            $sid_sql = absint( $filter_array['offset_lower'] );
+            $filter_sql[] = "a.id < {$sid_sql}";
         }