Changeset 13344

Timestamp:

10/25/2022 07:33:13 PM (11 months ago)

Author:

imath

Message:

Improve the activity loop to be able to get items below a max. ID

The $filter parameter of this loop now includes a new $offset_lower
argument making it possible to only retrieve activities having an ID
lower than this argument provided value.

We are using this filter to avoid a possible activity duplicate when
clicking on the "Load More" link.

Closes ​https://github.com/buddypress/buddypress/pull/29
Fixes #4535

Location:

trunk/src

Files:

• bp-activity/bp-activity-template.php (modified) (4 diffs)
• bp-activity/classes/class-bp-activity-activity.php (modified) (2 diffs)
• bp-templates/bp-legacy/buddypress-functions.php (modified) (1 diff)
• bp-templates/bp-legacy/js/buddypress.js (modified) (2 diffs)
• bp-templates/bp-nouveau/includes/functions.php (modified) (1 diff)
• bp-templates/bp-nouveau/js/buddypress-activity.js (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-template.php

@@ -273 +273 @@
             'secondary_id'      => false,        // Secondary object ID to filter on e.g. a post_id.
             'offset'            => false,        // Return only items >= this ID.
+            'offset_lower'      => false,        // Return only items < this ID.
             'since'             => false,        // Return only items recorded since this Y-m-d H:i:s date.
 
@@ -327 +328 @@
             'object' => $_GET['afilter']
         );
-    } elseif ( ! empty( $r['user_id'] ) || ! empty( $r['object'] ) || ! empty( $r['action'] ) || ! empty( $r['primary_id'] ) || ! empty( $r['secondary_id'] ) || ! empty( $r['offset'] ) || ! empty( $r['since'] ) ) {
+    } elseif ( ! empty( $r['user_id'] ) || ! empty( $r['object'] ) || ! empty( $r['action'] ) || ! empty( $r['primary_id'] ) || ! empty( $r['secondary_id'] ) || ! empty( $r['offset'] ) || ! empty( $r['offset_lower'] ) || ! empty( $r['since'] ) ) {
         $r['filter'] = array(
             'user_id'      => $r['user_id'],
@@ -335 +336 @@
             'secondary_id' => $r['secondary_id'],
             'offset'       => $r['offset'],
+            'offset_lower' => $r['offset_lower'],
             'since'        => $r['since']
         );
@@ -411 +413 @@
         global $activities_template;
 
-        $url  = bp_get_requested_url();
-        $link = add_query_arg( $activities_template->pag_arg, $activities_template->pag_page + 1, $url );
+        $url            = bp_get_requested_url();
+        $load_more_args = array(
+            $activities_template->pag_arg => $activities_template->pag_page + 1,
+        );
+
+        // Try to include the offset arg.
+        $last_displayed_activity = reset( $activities_template->activities );
+        if ( isset( $last_displayed_activity->id ) && $last_displayed_activity->id ) {
+            $load_more_args['offset_lower'] = (int) $last_displayed_activity->id;
+        }
+
+        $link = add_query_arg( $load_more_args, $url );
 
         /**

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -1923 +1923 @@
      *     @type int              $offset       Return only those items with an ID greater
      *                                          than the offset value.
+     *     @type int              $offset_lower Return only those items with an ID lower
+     *                                          than the offset value.
      *     @type string           $since        Return only those items that have a
      *                                          date_recorded value greater than a
@@ -1966 +1968 @@
             $sid_sql = absint( $filter_array['offset'] );
             $filter_sql[] = "a.id >= {$sid_sql}";
+        }
+
+        if ( ! empty( $filter_array['offset_lower'] ) ) {
+            $sid_sql = absint( $filter_array['offset_lower'] );
+            $filter_sql[] = "a.id < {$sid_sql}";
         }
 

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -766 +766 @@
     }
 
+    if ( ! empty( $_POST['offset_lower'] ) ) {
+        $qs[] = 'offset_lower=' . intval( $_POST['offset_lower'] );
+    }
+
     $object_search_text = bp_get_search_default_text( $object );
     if ( ! empty( $_POST['search_terms'] ) && is_string( $_POST['search_terms'] ) && $object_search_text != $_POST['search_terms'] && 'false' != $_POST['search_terms'] && 'undefined' != $_POST['search_terms'] )

trunk/src/bp-templates/bp-legacy/js/buddypress.js

@@ -432 +432 @@
         /* Load more updates at the end of the page */
         if ( target.parent().hasClass('load-more') ) {
+            var loadMoreLink = new URL( jq( target ).prop( 'href' ) ),
+                offsetLower = parseInt( loadMoreLink.searchParams.get( 'offset_lower' ), 10 ) || 0;
+
             if ( bp_ajax_request ) {
                 bp_ajax_request.abort();
@@ -449 +452 @@
                 'cookie': bp_get_cookies(),
                 'page': oldest_page,
+                'offset_lower': offsetLower,
                 'exclude_just_posted': just_posted.join(',')
             };

trunk/src/bp-templates/bp-nouveau/includes/functions.php

@@ -116 +116 @@
     if ( ! empty( $post_query['offset'] ) ) {
         $qs[] = 'offset=' . intval( $post_query['offset'] );
+    }
+
+    if ( ! empty( $post_query['offset_lower'] ) ) {
+        $qs[] = 'offset_lower=' . intval( $post_query['offset_lower'] );
     }
 

trunk/src/bp-templates/bp-nouveau/js/buddypress-activity.js

@@ -274 +274 @@
             // Load more activities
             } else if ( $( event.currentTarget ).hasClass( 'load-more' ) ) {
-                var next_page = ( Number( this.current_page ) * 1 ) + 1, self = this, search_terms = '';
+                var next_page = ( Number( this.current_page ) * 1 ) + 1, self = this, search_terms = '',
+                    loadMoreLink = $( event.currentTarget ).children().first(),
+                    offsetLower  = loadMoreLink ? bp.Nouveau.getLinkParams( loadMoreLink.prop( 'href' ), 'offset_lower' ) : 0;
 
                 // Stop event propagation
                 event.preventDefault();
 
-                $( event.currentTarget ).find( 'a' ).first().addClass( 'loading' );
+                loadMoreLink.addClass( 'loading' );
 
                 // reset the just posted
@@ -301 +303 @@
                     method              : 'append',
                     exclude_just_posted : this.just_posted.join( ',' ),
+                    offset_lower        : offsetLower,
                     target              : '#buddypress [data-bp-list] ul.bp-list'
                 } ).done( function( response ) {