Changeset 13338 for trunk/src/bp-templates/bp-nouveau/includes/classes/class-bp-buttons-group.php

Timestamp:

10/06/2022 11:12:28 PM (2 years ago)

Author:

imath

Message:

BP Nouveau: improve the BP_Buttons_Group class

Make sure filtering bp_nouveau_get_activity_entry_buttons to create a
button for a specific item's loop is not propagated to other items.

As the buttons of the group are cached, we need to eventually ignore some
cache data if this filter is used to generate button for specific items of
the loop instead of all items.

Props bouncingsprout

Fixes #8716

File:

• trunk/src/bp-templates/bp-nouveau/includes/classes/class-bp-buttons-group.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/classes/class-bp-buttons-group.php

@@ -126 +126 @@
      */
     public function update( $args = array() ) {
+        $button_group = array();
+
+        if ( is_array( $this->group ) ) {
+            $button_group = $this->group;
+        }
+
+        // If the cached button group args contains a key that is missing from args, remove it.
+        $diff = array_diff_key( $button_group, $args );
+        if ( $diff ) {
+            $this->group = array_intersect_key( $button_group, $args );
+        }
+
         foreach ( $args as $id => $params ) {
             if ( isset( $this->group[ $id ] ) ) {