Changeset 13324

Timestamp:

09/11/2022 06:22:23 PM (15 months ago)

Author:

espellcaste

Message:

Testing BuddyPress against its own/new PHP Code Sniffer (PHPCS).

The plugin is using its own custom PHP Code Sniffer (​https://github.com/buddypress/bp-coding-standards)

A non-blocking Github Action was introduced to test against this new code sniffer. Actual PHPCS fixes will be introduced in future commits.

Closes ​https://github.com/buddypress/buddypress/pull/21
See #7228

Location:

trunk

Files:

• .github/workflows/coding-standards.yml (added)
• .github/workflows/unit-tests.yml (modified) (3 diffs)
• .gitignore (modified) (1 diff)
• .phpcs (added)
• .phpcs/.gitkeep (added)
• composer.json (modified) (2 diffs)
• phpcs.xml.dist (added)

trunk/.github/workflows/unit-tests.yml

@@ -33 +33 @@
 
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup PHP
@@ -52 +52 @@
           composer --version
 
-      - name: Validate Composer
-        run: composer validate --strict
-
       - name: Install Composer dependencies
-        uses: ramsey/composer-install@v1
+        uses: ramsey/composer-install@v2
         with:
           composer-options: "--ignore-platform-reqs"
@@ -88 +85 @@
 
       - name: Running single site unit tests
+        if: ${{ success() || failure() }}
         run: npm run test-php
-        if: ${{ success() || failure() }}
 
       - name: Running multi site unit tests
+        if: ${{ success() || failure() }}
         run: npm run test-php-multisite
-        if: ${{ success() || failure() }}
 
       - name: Stop Docker environment
+        if: ${{ success() || failure() }}
         run: npm run wp-env stop
-        if: ${{ success() || failure() }}

trunk/.gitignore

@@ -24 +24 @@
 npm-debug.log
 
+.phpcs/*.json
+
 # The build directory.
 build

trunk/composer.json

@@ -33 +33 @@
         }
     },
+    "repositories": [
+        {
+            "url": "https://github.com/buddypress/bp-coding-standards.git",
+            "type": "git"
+        }
+    ],
     "require": {
         "composer/installers": "^1.10.0",
@@ -38 +44 @@
     },
     "require-dev": {
-        "phpcompatibility/phpcompatibility-wp": "^2.1.3",
-        "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
-        "squizlabs/php_codesniffer" : "^3.6.0",
-        "wp-coding-standards/wpcs": "~2.3.0",
+        "buddypress/bp-coding-standards": "dev-trunk",
         "wp-phpunit/wp-phpunit": "^6.0",
         "yoast/phpunit-polyfills": "^1.0.1"
     },
     "scripts": {
-        "test": "@php ./vendor/phpunit/phpunit/phpunit"
+        "test": "@php ./vendor/phpunit/phpunit/phpunit",
+        "phpcs" : "@php ./vendor/bin/phpcs"
     }
 }