Changeset 13314 for trunk/tests/phpunit/testcases/core/suggestions.php

Timestamp:

08/13/2022 08:58:51 AM (2 years ago)

Author:

imath

Message:

Fully enjoy Yoast’s PHPUnit polyfills

Using these polyfills let us use PHPUnit v9.x for our tests and add PHP 8.1 to our testing matrix. Some additional edits to our PHP unit tests suite were needed:

• Stop using PHPunit deprecated functions.
• Rename some BP_UnitTestCase methods to use Yoast's polyfills.
• Edit the PHP Unit test GH action and also run this action on pull requests.
• Update some composer dependencies, remove the one about phpunit/phpunit:^7.5 and add a new composer script to use PHPUnit v9.x.

Props renatonascalves, rafiahmedd

Closes ​https://github.com/buddypress/buddypress/pull/13
Fixes #8649

File:

• trunk/tests/phpunit/testcases/core/suggestions.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/core/suggestions.php

@@ -94 +94 @@
     }
 
-    public static function tearDownAfterClass() {
+    public static function tear_down_after_class() {
         foreach ( self::$group_ids as $group_id ) {
             groups_delete_group( $group_id );
@@ -110 +110 @@
     }
 
-    public function setUp() {
-        parent::setUp();
+    public function set_up() {
+        parent::set_up();
         $this->set_current_user( self::$current_user );
     }
 
-    public function tearDown() {
-        parent::tearDown();
+    public function tear_down() {
+        parent::tear_down();
         $this->set_current_user( self::$old_user_id );
     }
@@ -392 +392 @@
 
         $this->assertFalse( is_wp_error( $suggestions ) );
-        $this->assertInternalType( 'array', $suggestions );
+        $this->assertIsArray( $suggestions );
         $this->assertEmpty( $suggestions );
     }
@@ -403 +403 @@
 
         $this->assertFalse( is_wp_error( $suggestion ) );
-        $this->assertInternalType( 'array', $suggestion );
+        $this->assertIsArray(  $suggestion );
         $this->assertNotEmpty( $suggestion );
 
         $suggestion = array_shift( $suggestion );
 
-        $this->assertInternalType( 'object', $suggestion );
-        $this->assertAttributeNotEmpty( 'image', $suggestion );
-        $this->assertAttributeNotEmpty( 'ID', $suggestion );
-        $this->assertAttributeNotEmpty( 'name', $suggestion );
+        $this->assertIsObject( $suggestion );
+        $this->assertNotEmpty( $suggestion->image );
+        $this->assertNotEmpty( $suggestion->ID );
+        $this->assertNotEmpty( $suggestion->name );
     }
 
@@ -421 +421 @@
 
         $this->assertFalse( is_wp_error( $suggestions ) );
-        $this->assertInternalType( 'array', $suggestions );
+        $this->assertIsArray( $suggestions );
         $this->assertNotEmpty( $suggestions );
 
         foreach ( $suggestions as $suggestion ) {
-            $this->assertInternalType( 'object', $suggestion );
-            $this->assertAttributeNotEmpty( 'image', $suggestion );
-            $this->assertAttributeNotEmpty( 'ID', $suggestion );
-            $this->assertAttributeNotEmpty( 'name', $suggestion );
+            $this->assertIsObject( $suggestion );
+            $this->assertNotEmpty( $suggestion->image );
+            $this->assertNotEmpty( $suggestion->ID );
+            $this->assertNotEmpty( $suggestion->name );
         }
     }
@@ -458 +458 @@
 
         $this->assertFalse( is_wp_error( $suggestion ) );
-        $this->assertInternalType( 'array', $suggestion );
+        $this->assertIsArray( $suggestion );
         $this->assertNotEmpty( $suggestion );
 
         $suggestion = array_shift( $suggestion );
 
-        $this->assertInternalType( 'object', $suggestion );
-        $this->assertAttributeInternalType( 'string', 'image', $suggestion );
-        $this->assertAttributeInternalType( 'string', 'ID', $suggestion );
-        $this->assertAttributeInternalType( 'string', 'name', $suggestion );
+        $this->assertIsObject( $suggestion );
+        $this->assertIsString( $suggestion->image );
+        $this->assertIsString( $suggestion->ID );
+        $this->assertIsString( $suggestion->name );
     }