Changeset 13314 for trunk/tests/phpunit/testcases/activity/notifications.php

Timestamp:

08/13/2022 08:58:51 AM (2 years ago)

Author:

imath

Message:

Fully enjoy Yoast’s PHPUnit polyfills

Using these polyfills let us use PHPUnit v9.x for our tests and add PHP 8.1 to our testing matrix. Some additional edits to our PHP unit tests suite were needed:

• Stop using PHPunit deprecated functions.
• Rename some BP_UnitTestCase methods to use Yoast's polyfills.
• Edit the PHP Unit test GH action and also run this action on pull requests.
• Update some composer dependencies, remove the one about phpunit/phpunit:^7.5 and add a new composer script to use PHPUnit v9.x.

Props renatonascalves, rafiahmedd

Closes ​https://github.com/buddypress/buddypress/pull/13
Fixes #8649

File:

• trunk/tests/phpunit/testcases/activity/notifications.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/activity/notifications.php

@@ -12 +12 @@
     protected $a2;
 
-    public function setUp() {
-        parent::setUp();
+    public function set_up() {
+        parent::set_up();
         $this->current_user = get_current_user_id();
         $this->u1 = self::factory()->user->create();
@@ -23 +23 @@
          * When updating an activity, the following filter is fired to prevent sending more than one
          * notification. Once we've reached this filter all at_mentions tests fails so we need to
-         * temporarly remove it and restore it in $this->tearDown()
+         * temporarly remove it and restore it in $this->tear_down()
          */
         remove_filter( 'bp_activity_at_name_do_notifications', '__return_false' );
     }
 
-    public function tearDown() {
+    public function tear_down() {
         $this->set_current_user( $this->current_user );
-        parent::tearDown();
+        parent::tear_down();
 
         // Restore the filter
@@ -310 +310 @@
         $multiple = 'You have 2 new mentions';
 
-        $this->assertContains( $single, $format_tests['string_single'] );
-        $this->assertContains( $single, $format_tests['array_single']['text'] );
-        $this->assertContains( $multiple, $format_tests['string_multiple'] );
-        $this->assertContains( $multiple, $format_tests['array_multiple']['text'] );
+        $this->assertStringContainsString( $single, $format_tests['string_single'] );
+        $this->assertStringContainsString( $single, $format_tests['array_single']['text'] );
+        $this->assertStringContainsString( $multiple, $format_tests['string_multiple'] );
+        $this->assertStringContainsString( $multiple, $format_tests['array_multiple']['text'] );
 
         // Check filters