Changeset 13314 for trunk/tests/phpunit/includes/testcase.php

Timestamp:

08/13/2022 08:58:51 AM (3 years ago)

Author:

imath

Message:

Fully enjoy Yoast’s PHPUnit polyfills

Using these polyfills let us use PHPUnit v9.x for our tests and add PHP 8.1 to our testing matrix. Some additional edits to our PHP unit tests suite were needed:

• Stop using PHPunit deprecated functions.
• Rename some BP_UnitTestCase methods to use Yoast's polyfills.
• Edit the PHP Unit test GH action and also run this action on pull requests.
• Update some composer dependencies, remove the one about phpunit/phpunit:^7.5 and add a new composer script to use PHPUnit v9.x.

Props renatonascalves, rafiahmedd

Closes ​https://github.com/buddypress/buddypress/pull/13
Fixes #8649

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (7 diffs)

trunk/tests/phpunit/includes/testcase.php

@@ -31 +31 @@
      * @since 3.0.0
      */
-    public static function setUpBeforeClass() {
+    public static function set_up_before_class() {
         global $wpdb;
 
@@ -49 +49 @@
     }
 
-    public function setUp() {
-        parent::setUp();
+    public function set_up() {
+        parent::set_up();
 
         /*
@@ -75 +75 @@
     }
 
-    public function tearDown() {
+    public function tear_down() {
         global $wpdb;
 
         remove_action( 'bp_blogs_recorded_existing_blogs', array( $this, 'set_autocommit_flag' ) );
 
-        parent::tearDown();
+        parent::tear_down();
 
         // If we detect that a COMMIT has been triggered during the test, clean up blog and user fixtures.
@@ -116 +116 @@
         $deleted = parent::delete_user( $user_id );
 
-        // When called in tearDownAfterClass(), BP's cleanup functions may no longer be hooked.
+        // When called in tear_down_after_class(), BP's cleanup functions may no longer be hooked.
         if ( bp_is_active( 'activity' ) ) {
             bp_activity_remove_all_user_data( $user_id );
@@ -126 +126 @@
     }
 
-    function clean_up_global_scope() {
+    public function clean_up_global_scope() {
         buddypress()->bp_nav                = buddypress()->bp_options_nav = buddypress()->action_variables = buddypress()->canonical_stack = buddypress()->unfiltered_uri = $GLOBALS['bp_unfiltered_uri'] = array();
         buddypress()->current_component     = buddypress()->current_item = buddypress()->current_action = buddypress()->current_member_type = '';
@@ -181 +181 @@
     }
 
-    function assertPreConditions() {
-        parent::assertPreConditions();
+    public function assert_pre_conditions() {
+        parent::assert_pre_conditions();
 
         // Reinit some of the globals that might have been cleared by BP_UnitTestCase::clean_up_global_scope().
@@ -189 +189 @@
     }
 
-    function go_to( $url ) {
+    public function go_to( $url ) {
         $GLOBALS['bp']->loggedin_user = NULL;
         $GLOBALS['bp']->pages = bp_core_get_directory_pages();