Changeset 13309 for trunk/tests/phpunit/testcases/members/types.php

Timestamp:

08/08/2022 09:24:03 PM (2 years ago)

Author:

imath

Message:

Adapt to WP Cache API latest change about cache key requirements

In WordPress 6.1, a cache key needs to be an integer or a "not empty" string. See ​WP53818 changeset.

After analysing the failing PHPUnit failing tests, it seems we were not careful enough about cache key checks in a few cases:

• When generating an activity comment without a corresponding parent activity in our tests.
• When trying to cache a group membership ID for the group creator before this membership has been created.
• When trying to check if a member had a member type or a group had a group type using an empty string although into 2 of our unit tests.

Fixes #8727

File:

• trunk/tests/phpunit/testcases/members/types.php (modified) (1 diff)

trunk/tests/phpunit/testcases/members/types.php

@@ -374 +374 @@
         bp_register_member_type( 'foo' );
 
-        $this->assertFalse( bp_has_member_type( '', 'foo' ) );
+        $this->assertFalse( bp_has_member_type( 0, 'foo' ) );
     }