Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
08/08/2022 09:24:03 PM (21 months ago)
Author:
imath
Message:

Adapt to WP Cache API latest change about cache key requirements

In WordPress 6.1, a cache key needs to be an integer or a "not empty" string. See WP53818 changeset.

After analysing the failing PHPUnit failing tests, it seems we were not careful enough about cache key checks in a few cases:

  • When generating an activity comment without a corresponding parent activity in our tests.
  • When trying to cache a group membership ID for the group creator before this membership has been created.
  • When trying to check if a member had a member type or a group had a group type using an empty string although into 2 of our unit tests.

Fixes #8727

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-members/bp-members-functions.php

    r13293 r13309  
    32663266    // Bail if no valid member type was passed.
    32673267    if ( empty( $member_type ) || ! bp_get_member_type_object( $member_type ) ) {
     3268        return false;
     3269    }
     3270
     3271    $user_id = (int) $user_id;
     3272    if ( ! $user_id ) {
    32683273        return false;
    32693274    }
Note: See TracChangeset for help on using the changeset viewer.