Changeset 13309 for trunk/src/bp-groups/bp-groups-cache.php

Timestamp:

08/08/2022 09:24:03 PM (2 years ago)

Author:

imath

Message:

Adapt to WP Cache API latest change about cache key requirements

In WordPress 6.1, a cache key needs to be an integer or a "not empty" string. See ​WP53818 changeset.

After analysing the failing PHPUnit failing tests, it seems we were not careful enough about cache key checks in a few cases:

• When generating an activity comment without a corresponding parent activity in our tests.
• When trying to cache a group membership ID for the group creator before this membership has been created.
• When trying to check if a member had a member type or a group had a group type using an empty string although into 2 of our unit tests.

Fixes #8727

File:

• trunk/src/bp-groups/bp-groups-cache.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-cache.php

@@ -250 +250 @@
 function bp_groups_clear_user_group_cache_on_membership_save( BP_Groups_Member $member ) {
     wp_cache_delete( $member->user_id, 'bp_groups_memberships_for_user' );
-    wp_cache_delete( $member->id, 'bp_groups_memberships' );
+
+    if ( ! is_null( $member->id ) ) {
+        wp_cache_delete( $member->id, 'bp_groups_memberships' );
+    }
 }
 add_action( 'groups_member_before_save', 'bp_groups_clear_user_group_cache_on_membership_save' );