Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
08/08/2022 09:24:03 PM (21 months ago)
Author:
imath
Message:

Adapt to WP Cache API latest change about cache key requirements

In WordPress 6.1, a cache key needs to be an integer or a "not empty" string. See WP53818 changeset.

After analysing the failing PHPUnit failing tests, it seems we were not careful enough about cache key checks in a few cases:

  • When generating an activity comment without a corresponding parent activity in our tests.
  • When trying to cache a group membership ID for the group creator before this membership has been created.
  • When trying to check if a member had a member type or a group had a group type using an empty string although into 2 of our unit tests.

Fixes #8727

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-groups/bp-groups-cache.php

    r12429 r13309  
    250250function bp_groups_clear_user_group_cache_on_membership_save( BP_Groups_Member $member ) {
    251251    wp_cache_delete( $member->user_id, 'bp_groups_memberships_for_user' );
    252     wp_cache_delete( $member->id, 'bp_groups_memberships' );
     252
     253    if ( ! is_null( $member->id ) ) {
     254        wp_cache_delete( $member->id, 'bp_groups_memberships' );
     255    }
    253256}
    254257add_action( 'groups_member_before_save', 'bp_groups_clear_user_group_cache_on_membership_save' );
Note: See TracChangeset for help on using the changeset viewer.