Changeset 13304 for trunk/tests/phpunit/testcases/core/functions.php

Timestamp:

07/26/2022 01:31:07 PM (2 years ago)

Author:

imath

Message:

Start using a new strategy about deprecated functions management

The main goal of this commit is to change the way we load the files containing deprecated functions. This files are located into the src/bp-core/deprecated/ directory and there's one file for each version of BuddyPress we created to store the deprecate functions.

We noticed that these files were not necessarily loaded although they should have. This case happens to all users who firstly installed BuddyPress when its version was upper than 2.7.

From now on, here's how deprecated code will eventually load into your BuddyPress installation:

• First installs won't load deprecated code.
• Updated installs will load the 2 latest BuddyPress versions deprecated code.
• Defining the BP_IGNORE_DEPRECATED constant to true will change the 2 above points behavior ignoring any BuddyPress versions deprecated code.
• Defining the BP_IGNORE_DEPRECATED constant to false will change the 2 first points behavior loading all BuddyPress versions deprecated code.

Props djpaul, dcavins.

Fixes #8687

File:

• trunk/tests/phpunit/testcases/core/functions.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/functions.php

@@ -6 +6 @@
 
 class BP_Tests_Core_Functions extends BP_UnitTestCase {
+    protected $bp_initial_version;
+
     /**
      * @group bp_esc_sql_order
@@ -876 +878 @@
         return array_merge( $page_default_titles, array( 'newcomponent' => 'NewComponent' ) );
     }
+
+    public function override_initial_version() {
+        return $this->bp_initial_version;
+    }
+
+    /**
+     * @ticket BP8687
+     */
+    public function test_bp_get_deprecated_functions_versions() {
+        $current_version = (float) bp_get_version();
+        $versions        = bp_get_deprecated_functions_versions();
+
+        // When current version is the initial version, we shouldn't load deprecated functions files.
+        $this->assertTrue( is_array( $versions ) && ! $versions, 'Please check the list of `$deprecated_functions_versions` in `bp_get_deprecated_functions_versions()`. There should be one for each file of the `/src/bp-core/deprecated` directory.' );
+
+        // We should load the 2 lasts deprecated functions files.
+        $this->bp_initial_version = '8.0';
+
+        add_filter( 'pre_option__bp_initial_major_version', array( $this, 'override_initial_version' ), 10, 0 );
+
+        $versions = bp_get_deprecated_functions_versions();
+
+        remove_filter( 'pre_option__bp_initial_major_version', array( $this, 'override_initial_version' ), 10, 0 );
+
+        $this->assertTrue( 2 === count( $versions ) );
+
+        // Even if this version does not exist in deprecated functions files, we should load the 2 lasts.
+        $this->bp_initial_version = '1.0';
+
+        add_filter( 'pre_option__bp_initial_major_version', array( $this, 'override_initial_version' ), 10, 0 );
+
+        $versions = bp_get_deprecated_functions_versions();
+
+        remove_filter( 'pre_option__bp_initial_major_version', array( $this, 'override_initial_version' ), 10, 0 );
+
+        $this->assertTrue( 2 === count( $versions ) );
+    }
 }