Changeset 13304 for trunk/src/class-buddypress.php

Timestamp:

07/26/2022 01:31:07 PM (2 years ago)

Author:

imath

Message:

Start using a new strategy about deprecated functions management

The main goal of this commit is to change the way we load the files containing deprecated functions. This files are located into the src/bp-core/deprecated/ directory and there's one file for each version of BuddyPress we created to store the deprecate functions.

We noticed that these files were not necessarily loaded although they should have. This case happens to all users who firstly installed BuddyPress when its version was upper than 2.7.

From now on, here's how deprecated code will eventually load into your BuddyPress installation:

• First installs won't load deprecated code.
• Updated installs will load the 2 latest BuddyPress versions deprecated code.
• Defining the BP_IGNORE_DEPRECATED constant to true will change the 2 above points behavior ignoring any BuddyPress versions deprecated code.
• Defining the BP_IGNORE_DEPRECATED constant to false will change the 2 first points behavior loading all BuddyPress versions deprecated code.

Props djpaul, dcavins.

Fixes #8687

File:

• trunk/src/class-buddypress.php (modified) (4 diffs)

trunk/src/class-buddypress.php

@@ -464 +464 @@
          */
         $this->email_taxonomy_type = apply_filters( 'bp_email_tax_type', 'bp-email-type' );
+
+        /**
+         * Are PHPUnit tests running?
+         *
+         * @since 11.0.0
+         *
+         * @param bool $value True if PHPUnit tests are running, false otherwise.
+         */
+        $this->is_phpunit_running = function_exists( 'tests_add_filter' );
     }
 
@@ -484 +493 @@
         if ( ! defined( 'BP_DB_VERSION' ) ) {
             define( 'BP_DB_VERSION', $this->db_version );
-        }
-
-        // Define if deprecated functions should be ignored.
-        if ( ! defined( 'BP_IGNORE_DEPRECATED' ) ) {
-            define( 'BP_IGNORE_DEPRECATED', true );
         }
     }
@@ -536 +540 @@
         require $this->plugin_dir . 'bp-core/bp-core-blocks.php';
 
-        // Maybe load deprecated functionality (this double negative is proof positive!).
-        if ( ! bp_get_option( '_bp_ignore_deprecated_code', ! $this->load_deprecated ) ) {
-            require $this->plugin_dir . 'bp-core/deprecated/1.2.php';
-            require $this->plugin_dir . 'bp-core/deprecated/1.5.php';
-            require $this->plugin_dir . 'bp-core/deprecated/1.6.php';
-            require $this->plugin_dir . 'bp-core/deprecated/1.7.php';
-            require $this->plugin_dir . 'bp-core/deprecated/1.9.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.1.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.2.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.3.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.4.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.5.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.6.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.7.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.8.php';
-            require $this->plugin_dir . 'bp-core/deprecated/2.9.php';
-            require $this->plugin_dir . 'bp-core/deprecated/3.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/4.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/6.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/7.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/8.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/9.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/10.0.php';
-            require $this->plugin_dir . 'bp-core/deprecated/11.0.php';
-        }
+        // Get the list of versions needing their deprecated functions to be loaded.
+        $deprecated_functions_versions = bp_get_deprecated_functions_versions();
+
+        // Maybe load deprecated functionality.
+        if ( $deprecated_functions_versions && ! $this->is_phpunit_running ) {
+            $this->load_deprecated = true;
+
+            foreach ( $deprecated_functions_versions as $deprecated_functions_version ) {
+                // Load all or last 2 deprecated versions.
+                require $this->plugin_dir . sprintf( 'bp-core/deprecated/%s.php', $deprecated_functions_version );
+            }
+        }
 
         // Load wp-cli module if PHP 5.6+.
@@ -721 +711 @@
             ! in_array( $component, array( 'core', 'members' ), true ) &&
             ! bp_is_active( $component ) &&
-            ! function_exists( 'tests_add_filter' )
+            ! $this->is_phpunit_running
         ) {
             return;