Changeset 13299 for trunk/src/bp-templates/bp-nouveau/includes/members/template-tags.php

Timestamp:

07/22/2022 09:00:42 AM (4 years ago)

Author:

imath

Message:

Introduce a function to only get the Public Message button arguments

BP Nouveau is doing a complex workaround to only get these arguments without generating the BP_Button HTML output. bp_activity_get_public_message_button_args() eases the process of getting these arguments and removes the need for such a workaround.

Props hnla

See #7126
See #8722

File:

• trunk/src/bp-templates/bp-nouveau/includes/members/template-tags.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/members/template-tags.php

@@ -373 +373 @@
                 if ( 'profile' === $type ) {
                         if ( bp_is_active( 'activity' ) && bp_activity_do_mentions() ) {
+                                $button_args = bp_activity_get_public_message_button_args();
+
                                 /*
-                                 * This filter workaround is waiting for a core adaptation
-                                 * so that we can directly get the public message button arguments
-                                 * instead of the button.
-                                 *
-                                 * See https://buddypress.trac.wordpress.org/ticket/7126
+                                 * This button should remain as an anchor link.
+                                 * Hardcode the use of anchor elements if button arg passed in for other elements.
                                  */
-                                add_filter( 'bp_get_send_public_message_button', 'bp_nouveau_members_catch_button_args', 100, 1 );
-
-                                bp_get_send_public_message_button();
-
-                                remove_filter( 'bp_get_send_public_message_button', 'bp_nouveau_members_catch_button_args', 100, 1 );
-
-                                if ( isset( bp_nouveau()->members->button_args ) && bp_nouveau()->members->button_args ) {
-                                        $button_args = bp_nouveau()->members->button_args;
-
-                                        /*
-                                         * This button should remain as an anchor link.
-                                         * Hardcode the use of anchor elements if button arg passed in for other elements.
-                                         */
-                                        $buttons['public_message'] = array(
-                                                'id'                => $button_args['id'],
-                                                'position'          => 15,
-                                                'component'         => $button_args['component'],
-                                                'must_be_logged_in' => $button_args['must_be_logged_in'],
-                                                'block_self'        => $button_args['block_self'],
-                                                'parent_element'    => $parent_element,
-                                                'button_element'    => 'a',
-                                                'link_text'         => $button_args['link_text'],
-                                                'parent_attr'       => array(
-                                                        'id'    => $button_args['wrapper_id'],
-                                                        'class' => $parent_class,
-                                                ),
-                                                'button_attr'       => array(
-                                                        'href'             => $button_args['link_href'],
-                                                        'id'               => '',
-                                                        'class'            => $button_args['link_class'],
-                                                ),
-                                        );
-                                        unset( bp_nouveau()->members->button_args );
-                                }
+                                $buttons['public_message'] = array(
+                                        'id'                => $button_args['id'],
+                                        'position'          => 15,
+                                        'component'         => $button_args['component'],
+                                        'must_be_logged_in' => $button_args['must_be_logged_in'],
+                                        'block_self'        => $button_args['block_self'],
+                                        'parent_element'    => $parent_element,
+                                        'button_element'    => 'a',
+                                        'link_text'         => $button_args['link_text'],
+                                        'link_title'        => $button_args['link_title'],
+                                        'parent_attr'       => array(
+                                                'id'    => $button_args['wrapper_id'],
+                                                'class' => $parent_class,
+                                        ),
+                                        'button_attr'       => array(
+                                                'href'             => $button_args['link_href'],
+                                                'id'               => '',
+                                                'class'            => $button_args['link_class'],
+                                        ),
+                                );
                         }