Changeset 13280 for trunk/tests/phpunit/testcases/groups/functions.php

Timestamp:

05/18/2022 05:32:26 AM (4 years ago)

Author:

imath

Message:

Improve group members count query performance

[13103] introduced a change in 10.0.0 that can be very time consuming when a group has a lot of members.

To keep the main improvements of the referenced commit (only refreshing group members count when a user joins or leaves a group) but optimize queries performance, we are introducing a new way to count group members in the BP_Group_Member_Query.

We are also introducing a way to defer group members count when adding a batch of members to a group. Using bp_groups_defer_group_members_count() avoids to refresh the count each time a member of this batch is added. For more information about how to use this function, you can have a look at how BuddyPress is using it into src/bp-groups/bp-groups-admin.php.

Props dd32, espellcaste

See #8688 (trunk)

File:

• trunk/tests/phpunit/testcases/groups/functions.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/groups/functions.php

@@ -8 +8 @@
         static public $group_ids;
         static public $user_ids;
+        protected $did_group_member_count = 0;
 
         static public function wpSetUpBeforeClass( $factory ) {
@@ -343 +344 @@
                 $this->assertEquals( 2, groups_get_total_member_count( $g1 ) );
                 $this->assertEquals( 2, BP_Groups_Group::get_total_member_count( $g1 ) );
+        }
+
+        /**
+         * @group total_member_count
+         * @ticket BP8688
+         */
+        public function test_total_member_count_groups_inactive_user() {
+                $u1 = self::factory()->user->create();
+                $u2 = wp_insert_user( array(
+                        'user_pass'  => 'foobar',
+                        'user_login' => 'foobar',
+                        'user_email' => 'foobar@buddypress.org',
+                ) );
+
+                $g1 = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+                groups_join_group( $g1, $u2 );
+
+                $this->assertEquals( 1, groups_get_total_member_count( $g1 ) );
+        }
+
+        /**
+         * @group total_member_count
+         * @ticket BP8688
+         */
+        public function test_total_member_count_groups_spammed_user() {
+                $u1 = self::factory()->user->create();
+                $u2 = self::factory()->user->create();
+
+                $g1 = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+                groups_join_group( $g1, $u2 );
+                bp_core_process_spammer_status( $u2, 'spam' );
+
+                $this->assertEquals( 1, groups_get_total_member_count( $g1 ) );
+        }
+
+        /**
+         * @group total_member_count
+         * @ticket BP8688
+         */
+        public function test_total_member_count_groups_deferred() {
+                $u1 = self::factory()->user->create();
+                $g1 = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+                $members = array();
+                $this->did_group_member_count = 0;
+
+                add_filter( 'bp_groups_total_member_count', array( $this, 'filter_bp_groups_total_member_count' ) );
+
+                bp_groups_defer_group_members_count( true );
+                for ( $i = 1; $i < 6; $i++ ) {
+                        $members[ $i ] = self::factory()->user->create();
+                        groups_join_group( $g1, $members[ $i ] );
+                }
+                bp_groups_defer_group_members_count( false, $g1 );
+
+                remove_filter( 'bp_groups_total_member_count', array( $this, 'filter_bp_groups_total_member_count' ) );
+
+                $this->assertTrue( 1 === $this->did_group_member_count );
+                $this->assertEquals( count( $members ) + 1, groups_get_total_member_count( $g1 ) );
+        }
+
+        public function filter_bp_groups_total_member_count( $count ) {
+                $this->did_group_member_count += 1;
+                return $count;
         }