Changeset 13280 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

05/18/2022 05:32:26 AM (3 years ago)

Author:

imath

Message:

Improve group members count query performance

[13103] introduced a change in 10.0.0 that can be very time consuming when a group has a lot of members.

To keep the main improvements of the referenced commit (only refreshing group members count when a user joins or leaves a group) but optimize queries performance, we are introducing a new way to count group members in the BP_Group_Member_Query.

We are also introducing a way to defer group members count when adding a batch of members to a group. Using bp_groups_defer_group_members_count() avoids to refresh the count each time a member of this batch is added. For more information about how to use this function, you can have a look at how BuddyPress is using it into src/bp-groups/bp-groups-admin.php.

Props dd32, espellcaste

See #8688 (trunk)

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -1790 +1790 @@
      */
     public static function get_total_member_count( $group_id, $skip_cache = false ) {
-        $cache_key = 'total_member_count';
-        $count     = groups_get_groupmeta( $group_id, $cache_key );
+        $meta_key = 'total_member_count';
+        $count    = groups_get_groupmeta( $group_id, $meta_key );
 
         if ( false === $count || true === $skip_cache ) {
-            $members = groups_get_group_members(
+            $group_members = new BP_Group_Member_Query(
                 array(
                     'group_id'   => $group_id,
                     'group_role' => array( 'member', 'admin', 'mod' ),
-                    'type'       => 'active',
+                    'count'      => true,
                 )
             );
 
-            $count = $members['count'] ? $members['count'] : 0;
-
-            groups_update_groupmeta( $group_id, $cache_key, (int) $count );
+            $count = $group_members->total_users;
+            groups_update_groupmeta( $group_id, $meta_key, $count );
         }
 
@@ -1815 +1814 @@
          * @param int $group_id The ID of the group.
          */
-        return (int) apply_filters( 'bp_groups_total_member_count', (int) $count, (int) $group_id );
+        return (int) apply_filters( 'bp_groups_total_member_count', $count, (int) $group_id );
     }