Changeset 13270

Timestamp:

04/14/2022 07:38:35 PM (18 months ago)

Author:

imath

Message:

Avoid 2 superfluous private message notification queries

When viewing the single view of the thread, the potential notifications about it are marked as read into the messages_action_conversation() function. We don't need to do it again when looping into the thread messages.

This was revealed by a database error which was appearing when a user who had received more than 1 message from two different threads was directly viewing the single view of one of the threads.

Props mike80222, oztaser

Fixes #8676 (10.0 branch)

File:

• branches/10.0/src/bp-messages/bp-messages-notifications.php (modified) (1 diff)

branches/10.0/src/bp-messages/bp-messages-notifications.php

@@ -223 +223 @@
 
     /*
-     * Only run on the logged-in user's profile.
-     * If an admin visits a thread, it shouldn't change the read status.
+     * Bail if viewing the logged-in user's profile or a single message thread.
+     * The `messages_action_conversation()` action already marks the current thread as read.
      */
-    if ( ! bp_is_my_profile() ) {
+    if ( ! bp_is_my_profile() || ( bp_is_current_action( 'view' ) && bp_action_variable( 0 ) ) ) {
         return;
     }