Changeset 13236 for trunk/src/bp-blogs/bp-blogs-functions.php

Timestamp:

02/18/2022 11:06:15 PM (3 years ago)

Author:

r-a-y

Message:

Blogs: Fix pagination in BP_Blogs_Blog::get().

As part of #8488, we refactored BP_Blogs_Blog::get() to use an array
as the main function argument instead of passing multiple function
arguments.

In BP_Blogs_Blog::get(), the "per page" argument was previously
$limit, while in bp_blogs_get_blogs(), the "per page" argument
passed to BP_Blogs_Blog::get() is $r['per_page']. When swapping
over to the array function argument, $r['limit'] does not exist,
which broke pagination and would return all blogs instead.

This commit fixes the pagination problem by renaming the array key
from $r['limit'] to $r['per_page'].

Props imath.

Fixes #8633 (trunk)

File:

• trunk/src/bp-blogs/bp-blogs-functions.php (modified) (1 diff)

trunk/src/bp-blogs/bp-blogs-functions.php

@@ -1254 +1254 @@
  * @see BP_Blogs_Blog::get() for a description of parameters and return values.
  *
- * @param int|null $limit See {@BP_Blogs_Blog::get()}.
+ * @param int|null $per_page See {@BP_Blogs_Blog::get()}.
  * @param int|null $page  See {@BP_Blogs_Blog::get()}.
  * @return array See {@BP_Blogs_Blog::get()}.
  */
-function bp_blogs_get_random_blogs( $limit = null, $page = null ) {
+function bp_blogs_get_random_blogs( $per_page = null, $page = null ) {
     return BP_Blogs_Blog::get(
         array(
-            'type'  => 'random',
-            'limit' => $limit,
-            'page'  => $page
+            'type'     => 'random',
+            'per_page' => $per_page,
+            'page'     => $page
         )
     );