Changeset 13194

Timestamp:

12/23/2021 06:24:36 AM (5 years ago)

Author:

imath

Message:

BP Blocks: localize dynamic Blocks script data into site's footer

These script data were not printed into themes using the Full Site Editing feature, like Twenty Twenty-Two, which was generated a JavaScript error as soon as the user clicked on one of the links to filter the loop's items (friends, members or groups).
Moving the script localization to the site's footer makes sure the JavaScript error disappears and that links are fully functional. This change has also been successfully tested on regular WordPress themes.

See #8474

Location:

trunk/src

Files:

• bp-friends/bp-friends-blocks.php (modified) (2 diffs)
• bp-groups/bp-groups-blocks.php (modified) (2 diffs)
• bp-members/bp-members-blocks.php (modified) (2 diffs)

trunk/src/bp-friends/bp-friends-blocks.php

@@ -24 +24 @@
                 return;
         }
+
+        $path = sprintf(
+                '/%1$s/%2$s/%3$s',
+                bp_rest_namespace(),
+                bp_rest_version(),
+                buddypress()->members->id
+        );
+
+        wp_localize_script(
+                'bp-friends-script',
+                'bpFriendsSettings',
+                array(
+                        'path'  => ltrim( $path, '/' ),
+                        'root'  => esc_url_raw( get_rest_url() ),
+                        'nonce' => wp_create_nonce( 'wp_rest' ),
+                )
+        );
 
         // Include the common JS template.
@@ -220 +237 @@
                         wp_set_script_translations( 'bp-friends-script', 'buddypress' );
                         wp_enqueue_script( 'bp-friends-script' );
-                        wp_localize_script(
-                                'bp-friends-script',
-                                'bpFriendsSettings',
-                                array(
-                                        'path'  => ltrim( $path, '/' ),
-                                        'root'  => esc_url_raw( get_rest_url() ),
-                                        'nonce' => wp_create_nonce( 'wp_rest' ),
-                                )
-                        );
 
                         add_action( 'wp_footer', 'bp_friends_blocks_add_script_data', 1 );

trunk/src/bp-groups/bp-groups-blocks.php

@@ -325 +325 @@
                 return;
         }
+
+        $path = sprintf(
+                '/%1$s/%2$s/%3$s',
+                bp_rest_namespace(),
+                bp_rest_version(),
+                buddypress()->groups->id
+        );
+
+        wp_localize_script(
+                'bp-dynamic-groups-script',
+                'bpDynamicGroupsSettings',
+                array(
+                        'path'  => ltrim( $path, '/' ),
+                        'root'  => esc_url_raw( get_rest_url() ),
+                        'nonce' => wp_create_nonce( 'wp_rest' ),
+                )
+        );
 
         // Include the common JS template.
@@ -496 +513 @@
                         wp_set_script_translations( 'bp-dynamic-groups-script', 'buddypress' );
                         wp_enqueue_script( 'bp-dynamic-groups-script' );
-                        wp_localize_script(
-                                'bp-dynamic-groups-script',
-                                'bpDynamicGroupsSettings',
-                                array(
-                                        'path'  => ltrim( $path, '/' ),
-                                        'root'  => esc_url_raw( get_rest_url() ),
-                                        'nonce' => wp_create_nonce( 'wp_rest' ),
-                                )
-                        );
 
                         add_action( 'wp_footer', 'bp_groups_blocks_add_script_data', 1 );

trunk/src/bp-members/bp-members-blocks.php

@@ -346 +346 @@
                 return;
         }
+
+        $path = sprintf(
+                '/%1$s/%2$s/%3$s',
+                bp_rest_namespace(),
+                bp_rest_version(),
+                buddypress()->members->id
+        );
+
+        wp_localize_script(
+                'bp-dynamic-members-script',
+                'bpDynamicMembersSettings',
+                array(
+                        'path'  => ltrim( $path, '/' ),
+                        'root'  => esc_url_raw( get_rest_url() ),
+                        'nonce' => wp_create_nonce( 'wp_rest' ),
+                )
+        );
 
         // Include the common JS template.
@@ -513 +530 @@
                         wp_set_script_translations( 'bp-dynamic-members-script', 'buddypress' );
                         wp_enqueue_script( 'bp-dynamic-members-script' );
-                        wp_localize_script(
-                                'bp-dynamic-members-script',
-                                'bpDynamicMembersSettings',
-                                array(
-                                        'path'  => ltrim( $path, '/' ),
-                                        'root'  => esc_url_raw( get_rest_url() ),
-                                        'nonce' => wp_create_nonce( 'wp_rest' ),
-                                )
-                        );
 
                         add_action( 'wp_footer', 'bp_members_blocks_add_script_data', 1 );