Changeset 13189 for trunk/src/bp-templates/bp-nouveau/buddypress-functions.php

Timestamp:

12/16/2021 06:16:38 PM (4 years ago)

Author:

imath

Message:

Introduce a new constant/filter to enforce strong password in BP areas

You can now use the BP_MEMBERS_REQUIRED_PASSWORD_STRENGTH constant or alternatively the 'bp_members_user_pass_required_strength' filter to force members to use password satisfying a strength score from 4 (strong) to 1 (weak). For instance use define ( 'BP_MEMBERS_REQUIRED_PASSWORD_STRENGTH', 4 ); to enforce strong passwords.

This setting will only be applied to these 2 BuddyPress specific areas:

• the registration form,
• the General User's front-end profile settings tab.

PS: this commit also removes completely the password-verify script from the BP Nouveau Template Pack which was deprecated since BuddyPress 5.0.

Props niftythree, dcavins

Fixes #8589

File:

• trunk/src/bp-templates/bp-nouveau/buddypress-functions.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/buddypress-functions.php

@@ -385 +385 @@
         }
 
-        // Add The password verify if needed.
-        if ( bp_is_active( 'settings' ) || bp_get_signup_allowed() ) {
-            /**
-             * BP Nouveau is now directly using the `wp-admin/js/user-profile.js` script.
-             *
-             * Setting the user password is now more consistent with how WordPress handles it.
-             *
-             * @deprecated 5.0.0
-             */
-            $scripts['bp-nouveau-password-verify'] = array(
-                'file'         => 'js/password-verify%s.js',
-                'dependencies' => array( 'bp-nouveau', 'password-strength-meter' ),
-                'footer'       => true,
-            );
-        }
-
         foreach ( $scripts as $handle => $script ) {
             if ( ! isset( $script['file'] ) ) {
@@ -531 +515 @@
         if ( is_customize_preview() ) {
             $params['customizer_settings'] = bp_nouveau_get_temporary_setting( 'any' );
+        }
+
+        $required_password_strength = bp_members_user_pass_required_strength();
+        if ( $required_password_strength ) {
+            $params['bpPasswordVerify'] = array(
+                'tooWeakPasswordWarning' => __( 'Your password is too weak, please use a stronger password.', 'buddypress' ),
+                'requiredPassStrength'   => bp_members_user_pass_required_strength(),
+            );
         }