Changeset 13184 for trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

Timestamp:

12/12/2021 02:09:02 PM (3 years ago)

Author:

imath

Message:

Support date queries for Members, Groups and Sites

According to components, date queries can be restricted to a limited list of loop types:

• For Members, the $type parameter in bp_has_members() needs to be either active, newest, random or online.
• For Groups, the $type parameter in bp_has_groups() needs to be either active or newest.
• For sites, the $type parameter in bp_has_blogs() needs to be either active or newest.

Props r-a-y

Fixes #8488

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (2 diffs)

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -849 +849 @@
      * We use BP_Date_Query, which extends WP_Date_Query, to do the heavy lifting
      * of parsing the date_query array and creating the necessary SQL clauses.
-     * However, since BP_Notifications_Notification::get() builds its SQL
-     * differently than WP_Query, we have to alter the return value (stripping
-     * the leading AND keyword from the query).
      *
      * @since 2.3.0
@@ -860 +857 @@
      */
     public static function get_date_query_sql( $date_query = array() ) {
-
-        // Bail if not a proper date query format.
-        if ( empty( $date_query ) || ! is_array( $date_query ) ) {
-            return '';
-        }
-
-        // Date query.
-        $date_query = new BP_Date_Query( $date_query, 'date_notified' );
-
-        // Strip the leading AND - it's handled in get().
-        return preg_replace( '/^\sAND/', '', $date_query->get_sql() );
+        return BP_Date_Query::get_where_sql( $date_query, 'n.date_notified' );
     }