Changeset 13150 for trunk/tests/phpunit/testcases/activity/class.BP_Activity_Activity.php

Timestamp:

11/14/2021 03:51:15 PM (3 years ago)

Author:

imath

Message:

Group the BP_Activity_Activity::get_id() method params into an array

Deprecate old arguments and add backward compatibility for users still using these.

Props oztaser

Fixes #8596

File:

• trunk/tests/phpunit/testcases/activity/class.BP_Activity_Activity.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/activity/class.BP_Activity_Activity.php

@@ -465 +465 @@
         ) );
 
-        $activity = BP_Activity_Activity::get_id( false, false, false, 523, false, false, false, false );
+        $args = array(
+            'item_id' => 523,
+        );
+
+        $activity = BP_Activity_Activity::get_id( $args );
         $this->assertEquals( $a1, $activity );
     }
@@ -471 +475 @@
     /**
      * @group get_id
+     * @group BP8596
+     * @expectedDeprecated BP_Activity_Activity::get_id
+     */
+    public function test_get_id_with_deprecated_args() {
+        $a1 = self::factory()->activity->create( array(
+            'item_id' => 573,
+        ) );
+        $a2 = self::factory()->activity->create( array(
+            'item_id' => 1098,
+        ) );
+
+        $activity = BP_Activity_Activity::get_id( false, false, false, 1098, false, false, false, false );
+        $this->assertEquals( $a2, $activity );
+    }
+
+    /**
+     * @group get_id
      */
     public function test_get_id_with_secondary_item_id() {
@@ -480 +501 @@
         ) );
 
-        $activity = BP_Activity_Activity::get_id( false, false, false, false, 523, false, false, false );
+        $args = array(
+            'secondary_item_id' => 523,
+        );
+
+        $activity = BP_Activity_Activity::get_id( $args );
         $this->assertEquals( $a1, $activity );
     }