Changeset 13149 for trunk/src/bp-activity/bp-activity-functions.php

Timestamp:

11/14/2021 03:16:38 PM (3 years ago)

Author:

imath

Message:

Improve the bp_activity_comments cache management

This cache should also be cleared when:

• an activity comment has been marked as spam/ham.
• an activity comment has been updated.

Props oztaser

Fixes #8296

File:

• trunk/src/bp-activity/bp-activity-functions.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-functions.php

@@ -3596 +3596 @@
     wp_cache_delete( 'bp_activity_sitewide_front', 'bp' );
 
+    if ( 'activity_comment' === $activity->type ) {
+        $activity_id = $activity->item_id;
+    } else {
+        $activity_id = $activity->id;
+    }
+
     // Clear the activity comment cache for this activity item.
-    wp_cache_delete( $activity->id, 'bp_activity_comments' );
+    wp_cache_delete( $activity_id, 'bp_activity_comments' );
 
     // If Akismet is active, and this was a manual spam/ham request, stop Akismet checking the activity.
@@ -3643 +3649 @@
     wp_cache_delete( 'bp_activity_sitewide_front', 'bp' );
 
+    if ( 'activity_comment' === $activity->type ) {
+        $activity_id = $activity->item_id;
+    } else {
+        $activity_id = $activity->id;
+    }
+
     // Clear the activity comment cache for this activity item.
-    wp_cache_delete( $activity->id, 'bp_activity_comments' );
+    wp_cache_delete( $activity_id, 'bp_activity_comments' );
 
     // If Akismet is active, and this was a manual spam/ham request, stop Akismet checking the activity.