Changeset 13147 for trunk/tests/phpunit/testcases/messages/class.bp-messages-thread.php

Timestamp:

11/13/2021 06:40:37 PM (3 years ago)

Author:

espellcaste

Message:

Sanitize all ORDER BY (ASC/DESC) values using the bp_esc_sql_order helper function where possible.

BuddyPress is not consistent on how it escapes ORDER BY (ASC/DESC) values provided by the developers/users. This commit improves that by using the bp_esc_sql_order helper function where possible.

Props imath

Fixes #8576

File:

• trunk/tests/phpunit/testcases/messages/class.bp-messages-thread.php (modified) (1 diff)

trunk/tests/phpunit/testcases/messages/class.bp-messages-thread.php

@@ -141 +141 @@
         );
 
+        // Testing sort with lowercase and space.
+        $thread = new BP_Messages_Thread( $message_1->thread_id, '    desc' );
+        $this->assertEquals(
+            array( $message_2->id, $message_1->id ),
+            wp_list_pluck( $thread->messages, 'id' )
+        );
+
         // Now sorting via the helper method.
         $messages = BP_Messages_Thread::get_messages( $message_1->thread_id, array( 'order' => 'desc' ) );