Changeset 13147 for trunk/src/bp-messages/classes/class-bp-messages-thread-template.php

Timestamp:

11/13/2021 06:40:37 PM (3 years ago)

Author:

espellcaste

Message:

Sanitize all ORDER BY (ASC/DESC) values using the bp_esc_sql_order helper function where possible.

BuddyPress is not consistent on how it escapes ORDER BY (ASC/DESC) values provided by the developers/users. This commit improves that by using the bp_esc_sql_order helper function where possible.

Props imath

Fixes #8576

File:

• trunk/src/bp-messages/classes/class-bp-messages-thread-template.php (modified) (1 diff)

trunk/src/bp-messages/classes/class-bp-messages-thread-template.php

@@ -85 +85 @@
      *
      * @param int    $thread_id ID of the message thread to display.
-     * @param string $order     Order to show the thread's messages in.
+     * @param string $order     Optional. Order to show the thread's messages in.
+     *                          Default: 'ASC'.
      * @param array  $args      Array of arguments for the query.
      */