Changeset 13147 for trunk/src/bp-blogs/bp-blogs-template.php

Timestamp:

11/13/2021 06:40:37 PM (3 years ago)

Author:

espellcaste

Message:

Sanitize all ORDER BY (ASC/DESC) values using the bp_esc_sql_order helper function where possible.

BuddyPress is not consistent on how it escapes ORDER BY (ASC/DESC) values provided by the developers/users. This commit improves that by using the bp_esc_sql_order helper function where possible.

Props imath

Fixes #8576

File:

• trunk/src/bp-blogs/bp-blogs-template.php (modified) (3 diffs)

trunk/src/bp-blogs/bp-blogs-template.php

@@ -98 +98 @@
 /**
  * Rewind the blogs and reset blog index.
+ *
+ * @global BP_Blogs_Template $blogs_template {@link BP_Blogs_Template}
  */
 function bp_rewind_blogs() {
@@ -112 +114 @@
  * display a list of activity items.
  *
- * @global object $blogs_template {@link BP_Blogs_Template}
+ * @global BP_Blogs_Template $blogs_template {@link BP_Blogs_Template}
  *
  * @param array|string $args {
@@ -134 +136 @@
  *                                      'active', 'alphabetical', 'newest', or 'random'.
  *     @type array    $include_blog_ids Array of blog IDs to limit results to.
- *     @type string   $sort             'ASC' or 'DESC'. Default: 'DESC'.
  *     @type string   $search_terms     Limit results by a search term. Default: the value of `$_REQUEST['s']` or
  *                                      `$_REQUEST['sites_search']`, if present.