Changeset 13140 for trunk/src/bp-core/bp-core-wpabstraction.php

Timestamp:

11/07/2021 05:22:42 PM (4 years ago)

Author:

imath

Message:

Raise WordPress required version to 5.4

BuddyPress 10.0.0 will require at least WordPress 5.4. The BP Development team took this decision on October 6 (2021) according to our ​guideline about WordPress version compatibility.

• Add WordPress 5.4 to the WordPress versions tested into our PHPUnit GitHub action.
• Deprecate the bp.apiRequest script which was introduced to polyfill the wp.apiRequest one. Plugin developers are encouraged to directly use the wp.apiRequest script. Please note the bp.apiRequest script will be completely removed in a next major BuddyPress version.
• Deprecate the bp_insert_site_hook() and bp_delete_site_hook() function which were introduced to make sure to use the best hook according to the installed WordPress version when creating a new site or deleting an existing one.

At least one more commit is required to finish this "raising" process, as BP Blocks do not need anymore the CompatibiltyServerSideRender component we introduced to preserve back compatibility with WordPress version older than 5.3.

Props oztaser

See #8571

File:

• trunk/src/bp-core/bp-core-wpabstraction.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-wpabstraction.php

@@ -310 +310 @@
 
 /**
- * Returns the name of the hook to use once a WordPress Site is inserted into the Database.
- *
- * WordPress 5.1.0 deprecated the `wpmu_new_blog` action. As BuddyPress is supporting WordPress back
- * to 4.9.0, this function makes sure we are using the new hook `wp_initialize_site` when the current
- * WordPress version is upper or equal to 5.1.0 and that we keep on using `wpmu_new_blog` for earlier
- * versions of WordPress.
- *
- * @since 6.0.0
- *
- * @return string The name of the hook to use.
- */
-function bp_insert_site_hook() {
-    $wp_hook = 'wpmu_new_blog';
-
-    if ( function_exists( 'wp_insert_site' ) ) {
-        $wp_hook = 'wp_initialize_site';
-    }
-
-    return $wp_hook;
-}
-
-/**
  * Catch the new site data for a later use.
  *
@@ -400 +378 @@
     do_action( 'bp_insert_site', $site_id, $user_id, $domain, $path, $network_id, $meta );
 }
-add_action( bp_insert_site_hook(), 'bp_insert_site' );
-
-/**
- * Returns the name of the hook to use once a WordPress Site is deleted.
- *
- * WordPress 5.1.0 deprecated the `delete_blog` action. As BuddyPress is supporting WordPress back
- * to 4.9.0, this function makes sure we are using the new hook `wp_validate_site_deletion` when the
- * current WordPress version is upper or equal to 5.1.0 and that we keep on using `delete_blog` for
- * earlier versions of WordPress.
- *
- * @since 6.0.0
- *
- * @return string The name of the hook to use.
- */
-function bp_delete_site_hook() {
-    $wp_hook = 'delete_blog';
-
-    if ( function_exists( 'wp_delete_site' ) ) {
-        $wp_hook = 'wp_validate_site_deletion';
-    }
-
-    return $wp_hook;
-}
+add_action( 'wp_initialize_site', 'bp_insert_site' );
 
 /**
@@ -472 +428 @@
     do_action( 'bp_delete_site', $site_id, $drop );
 }
-add_action( bp_delete_site_hook(), 'bp_delete_site', 10, 2 );
-
-if ( ! function_exists( 'wp_parse_list' ) ) {
-    /**
-     * Cleans up an array, comma- or space-separated list of scalar values.
-     *
-     * As BuddyPress supports older WordPress versions than 5.1 (4.9 & 5.0),
-     * the BP REST API needs this function to be available.
-     *
-     * @since 7.0.0
-     *
-     * @param array|string $list List of values.
-     * @return array Sanitized array of values.
-     */
-    function wp_parse_list( $list ) {
-        if ( ! is_array( $list ) ) {
-            return preg_split( '/[\s,]+/', $list, -1, PREG_SPLIT_NO_EMPTY );
-        }
-
-        return $list;
-    }
-}
+add_action( 'wp_validate_site_deletion', 'bp_delete_site', 10, 2 );