Changeset 13140 for trunk/src/bp-core/bp-core-rest-api.php

Timestamp:

11/07/2021 05:22:42 PM (4 years ago)

Author:

imath

Message:

Raise WordPress required version to 5.4

BuddyPress 10.0.0 will require at least WordPress 5.4. The BP Development team took this decision on October 6 (2021) according to our ​guideline about WordPress version compatibility.

• Add WordPress 5.4 to the WordPress versions tested into our PHPUnit GitHub action.
• Deprecate the bp.apiRequest script which was introduced to polyfill the wp.apiRequest one. Plugin developers are encouraged to directly use the wp.apiRequest script. Please note the bp.apiRequest script will be completely removed in a next major BuddyPress version.
• Deprecate the bp_insert_site_hook() and bp_delete_site_hook() function which were introduced to make sure to use the best hook according to the installed WordPress version when creating a new site or deleting an existing one.

At least one more commit is required to finish this "raising" process, as BP Blocks do not need anymore the CompatibiltyServerSideRender component we introduced to preserve back compatibility with WordPress version older than 5.3.

Props oztaser

See #8571

File:

• trunk/src/bp-core/bp-core-rest-api.php (modified) (5 diffs)

trunk/src/bp-core/bp-core-rest-api.php

@@ -51 +51 @@
      * Filter here to disable the BP REST API.
      *
-     * The BP REST API requires at least WordPress 4.7.0
+     * The BP REST API requires at least WordPress 4.7.0.
      *
      * @since 5.0.0
@@ -57 +57 @@
      * @param boolean $value True if the BP REST API is available. False otherwise.
      */
-    return apply_filters( 'bp_rest_api_is_available', bp_is_running_wp( '4.7.0' ) && bp_rest_in_buddypress() ) || bp_rest_is_plugin_active();
+    return apply_filters( 'bp_rest_api_is_available', bp_rest_in_buddypress() ) || bp_rest_is_plugin_active();
 }
 
@@ -64 +64 @@
  *
  * @since 5.0.0
+ * @deprecated 10.0.0
  */
 function bp_rest_api_register_request_script() {
@@ -70 +71 @@
     }
 
-    $dependencies = array( 'jquery' );
-
-    // The wrapper for WP REST API requests was introduced in WordPress 4.9.0.
-    if ( wp_script_is( 'wp-api-request', 'registered' ) ) {
-        $dependencies = array( 'wp-api-request' );
-    }
-
     wp_register_script(
         'bp-api-request',
         sprintf( '%1$sbp-core/js/bp-api-request%2$s.js', buddypress()->plugin_url, bp_core_get_minified_asset_suffix() ),
-        $dependencies,
+        array( 'jquery', 'wp-api-request' ),
         bp_get_version(),
         true
@@ -89 +83 @@
         'bpApiSettings',
         array(
-            'root'            => esc_url_raw( get_rest_url() ),
-            'nonce'           => wp_create_nonce( 'wp_rest' ),
-            'unexpectedError' => __( 'An unexpected error occured. Please try again.', 'buddypress' ),
+            'unexpectedError'   => __( 'An unexpected error occured. Please try again.', 'buddypress' ),
+            'deprecatedWarning' => __( 'The bp.apiRequest function is deprecated since BuddyPress 10.0.0, please use wp.apiRequest instead.', 'buddypress' ),
         )
     );