Changeset 13130

Timestamp:

10/28/2021 01:36:47 PM (3 years ago)

Author:

imath

Message:

Directly fetch post author activities into the Latest Activities block

When used into the Post Editor, it's the expected behavior.

Props vapvarun

Fixes #8593

Location:

trunk/src

Files:

• bp-activity/js/blocks/latest-activities.js (modified) (10 diffs)
• js/bp-activity/js/blocks/latest-activities/edit.js (modified) (1 diff)

trunk/src/bp-activity/js/blocks/latest-activities.js

@@ -129 +129 @@
  * WordPress dependencies.
  */
-var _wp = wp,
-    InspectorControls = _wp.blockEditor.InspectorControls,
-    _wp$components = _wp.components,
-    Disabled = _wp$components.Disabled,
-    PanelBody = _wp$components.PanelBody,
-    RangeControl = _wp$components.RangeControl,
-    SelectControl = _wp$components.SelectControl,
-    TextControl = _wp$components.TextControl,
-    _wp$element = _wp.element,
-    Fragment = _wp$element.Fragment,
-    createElement = _wp$element.createElement,
-    __ = _wp.i18n.__;
+const {
+  blockEditor: {
+    InspectorControls
+  },
+  components: {
+    Disabled,
+    PanelBody,
+    RangeControl,
+    SelectControl,
+    TextControl
+  },
+  element: {
+    Fragment,
+    createElement
+  },
+  i18n: {
+    __
+  }
+} = wp;
 /**
  * BuddyPress dependencies.
  */
 
-var _bp = bp,
-    ServerSideRender = _bp.blockComponents.ServerSideRender,
-    _bp$blockData = _bp.blockData,
-    currentPostId = _bp$blockData.currentPostId,
-    activityTypes = _bp$blockData.activityTypes;
-
-var editDynamicActivitiesBlock = function editDynamicActivitiesBlock(_ref) {
-  var attributes = _ref.attributes,
-      setAttributes = _ref.setAttributes;
-  var postId = attributes.postId,
-      maxActivities = attributes.maxActivities,
-      type = attributes.type,
-      title = attributes.title;
-  var post = currentPostId();
-  var types = activityTypes();
+const {
+  blockComponents: {
+    ServerSideRender
+  },
+  blockData: {
+    currentPostId,
+    activityTypes
+  }
+} = bp;
+
+const editDynamicActivitiesBlock = ({
+  attributes,
+  setAttributes
+}) => {
+  const {
+    postId,
+    maxActivities,
+    type,
+    title
+  } = attributes;
+  const post = currentPostId();
+  const types = activityTypes();
 
   if (!postId && post) {
@@ -165 +179 @@
       postId: post
     });
+
+    if (!attributes.postId) {
+      attributes.postId = post;
+    }
   }
 
@@ -174 +192 @@
     label: __('Title', 'buddypress'),
     value: title,
-    onChange: function onChange(text) {
+    onChange: text => {
       setAttributes({
         title: text
@@ -182 +200 @@
     label: __('Maximum amount to display', 'buddypress'),
     value: maxActivities,
-    onChange: function onChange(value) {
-      return setAttributes({
-        maxActivities: value
-      });
-    },
+    onChange: value => setAttributes({
+      maxActivities: value
+    }),
     min: 1,
     max: 10,
@@ -195 +211 @@
     value: type,
     options: types,
-    onChange: function onChange(option) {
+    onChange: option => {
       setAttributes({
         type: option
@@ -219 +235 @@
  * WordPress dependencies.
  */
-var _wp = wp,
-    createBlock = _wp.blocks.createBlock;
+const {
+  blocks: {
+    createBlock
+  }
+} = wp;
 /**
  * Transforms Nouveau Activity Widget to Activity Block.
@@ -227 +246 @@
  */
 
-var transforms = {
+const transforms = {
   from: [{
     type: 'block',
     blocks: ['core/legacy-widget'],
-    isMatch: function isMatch(_ref) {
-      var idBase = _ref.idBase,
-          instance = _ref.instance;
-
+    isMatch: ({
+      idBase,
+      instance
+    }) => {
       if (!(instance !== null && instance !== void 0 && instance.raw)) {
         return false;
@@ -241 +260 @@
       return idBase === 'bp_latest_activities';
     },
-    transform: function transform(_ref2) {
-      var instance = _ref2.instance;
-      var regex = /i:\d*;s:\d*:"(.*?)";/gmi;
-      var types = [];
-      var matches;
+    transform: ({
+      instance
+    }) => {
+      const regex = /i:\d*;s:\d*:"(.*?)";/gmi;
+      let types = [];
+      let matches;
 
       while ((matches = regex.exec(instance.raw.type)) !== null) {
@@ -252 +272 @@
         }
 
-        matches.forEach(function (match, groupIndex) {
+        matches.forEach((match, groupIndex) => {
           if (1 === groupIndex) {
             types.push(match);
@@ -281 +301 @@
  * WordPress dependencies.
  */
-var _wp = wp,
-    registerBlockType = _wp.blocks.registerBlockType,
-    __ = _wp.i18n.__;
+const {
+  blocks: {
+    registerBlockType
+  },
+  i18n: {
+    __
+  }
+} = wp;
 /**
  * Internal dependencies.

trunk/src/js/bp-activity/js/blocks/latest-activities/edit.js

@@ -42 +42 @@
     if ( ! postId && post ) {
         setAttributes( { postId: post } );
+        if ( ! attributes.postId ) {
+            attributes.postId = post;
+        }
     }