Changeset 13112 for trunk/src/bp-notifications/actions/bulk-manage.php

Timestamp:

09/19/2021 03:58:09 PM (4 years ago)

Author:

imath

Message:

Improve SQL performance when updating/deleting a list of notifications

Instead of looping into a list of notifications to run an update/delete query for each notification, update/delete a list of notifications using a single query. Use primarly this change for message thread notifications and bulk notification actions.

Mainly introduces 2 new static methods to BP_Notifications_Notification:

• BP_Notifications_Notification::update_id_list() let you update a list of notifications using their notification IDs or component item IDs.
• BP_Notifications_Notification::delete_id_list() let you delete a list of notifications using their notification IDs or component item IDs.

Props oztaser

Fixes #8426

File:

• trunk/src/bp-notifications/actions/bulk-manage.php (modified) (2 diffs)

trunk/src/bp-notifications/actions/bulk-manage.php

@@ -13 +13 @@
  * @since 2.2.0
  *
- * @return bool
+ * @return false|void
  */
 function bp_notifications_action_bulk_manage() {
@@ -43 +43 @@
     switch ( $action ) {
         case 'delete':
-            foreach ( $notifications as $notification ) {
-                bp_notifications_delete_notification( $notification );
-            }
+            bp_notifications_delete_notifications_by_ids( $notifications );
             bp_core_add_message( __( 'Notifications deleted.', 'buddypress' ) );
             break;
 
         case 'read':
-            foreach ( $notifications as $notification ) {
-                bp_notifications_mark_notification( $notification, false );
-            }
+            bp_notifications_mark_notifications_by_ids( $notifications, false );
             bp_core_add_message( __( 'Notifications marked as read', 'buddypress' ) );
             break;
 
         case 'unread':
-            foreach ( $notifications as $notification ) {
-                bp_notifications_mark_notification( $notification, true );
-            }
+            bp_notifications_mark_notifications_by_ids( $notifications, true );
             bp_core_add_message( __( 'Notifications marked as unread.', 'buddypress' ) );
             break;