Changeset 13112 for trunk/src/bp-messages/classes/class-bp-messages-thread.php

Timestamp:

09/19/2021 03:58:09 PM (3 years ago)

Author:

imath

Message:

Improve SQL performance when updating/deleting a list of notifications

Instead of looping into a list of notifications to run an update/delete query for each notification, update/delete a list of notifications using a single query. Use primarly this change for message thread notifications and bulk notification actions.

Mainly introduces 2 new static methods to BP_Notifications_Notification:

• BP_Notifications_Notification::update_id_list() let you update a list of notifications using their notification IDs or component item IDs.
• BP_Notifications_Notification::delete_id_list() let you delete a list of notifications using their notification IDs or component item IDs.

Props oztaser

Fixes #8426

File:

• trunk/src/bp-messages/classes/class-bp-messages-thread.php (modified) (4 diffs)

trunk/src/bp-messages/classes/class-bp-messages-thread.php

@@ -767 +767 @@
         }
 
-        $bp     = buddypress();
-        $retval = $wpdb->query( $wpdb->prepare( "UPDATE {$bp->messages->table_name_recipients} SET unread_count = 0 WHERE user_id = %d AND thread_id = %d", $user_id, $thread_id ) );
+        $bp       = buddypress();
+        $num_rows = $wpdb->query( $wpdb->prepare( "UPDATE {$bp->messages->table_name_recipients} SET unread_count = 0 WHERE user_id = %d AND thread_id = %d", $user_id, $thread_id ) );
 
         wp_cache_delete( 'thread_recipients_' . $thread_id, 'bp_messages' );
@@ -778 +778 @@
          * @since 2.8.0
          * @since 9.0.0 Added the `user_id` parameter.
+         * @since 10.0.0 Added the `$num_rows` parameter.
          *
          * @param int $thread_id The message thread ID.
          * @param int $user_id   The user the thread will be marked as read.
+         * @param bool|int $num_rows    Number of threads marked as unread or false on error.
          */
-        do_action( 'messages_thread_mark_as_read', $thread_id, $user_id );
-
-        return $retval;
+        do_action( 'messages_thread_mark_as_read', $thread_id, $user_id, $num_rows );
+
+        return $num_rows;
     }
 
@@ -811 +813 @@
         }
 
-        $bp     = buddypress();
-        $retval = $wpdb->query( $wpdb->prepare( "UPDATE {$bp->messages->table_name_recipients} SET unread_count = 1 WHERE user_id = %d AND thread_id = %d", $user_id, $thread_id ) );
+        $bp       = buddypress();
+        $num_rows = $wpdb->query( $wpdb->prepare( "UPDATE {$bp->messages->table_name_recipients} SET unread_count = 1 WHERE user_id = %d AND thread_id = %d", $user_id, $thread_id ) );
 
         wp_cache_delete( 'thread_recipients_' . $thread_id, 'bp_messages' );
@@ -822 +824 @@
          * @since 2.8.0
          * @since 9.0.0  Added the `$user_id` parameter.
-         * @since 10.0.0 Added the `$retval` parameter.
+         * @since 10.0.0 Added the `$num_rows` parameter.
          *
          * @param int      $thread_id The message thread ID.
          * @param int      $user_id   The user the thread will be marked as unread.
-         * @param bool|int $retval     =Number of threads marked as unread or false on error.
+         * @param bool|int $num_rows  Number of threads marked as unread or false on error.
          */
-        do_action( 'messages_thread_mark_as_unread', $thread_id, $user_id, $retval );
-
-        return $retval;
+        do_action( 'messages_thread_mark_as_unread', $thread_id, $user_id, $num_rows );
+
+        return $num_rows;
     }