Changeset 13108 for trunk/src/bp-core/bp-core-buddybar.php

Timestamp:

09/12/2021 08:43:39 PM (5 years ago)

Author:

espellcaste

Message:

Update all references from wp_parse_args to bp_parse_args.

Also, add WPCS improvements to align bp_parse_args correctly.

Props imath
Fixes #8564

File:

• trunk/src/bp-core/bp-core-buddybar.php (modified) (6 diffs)

trunk/src/bp-core/bp-core-buddybar.php

@@ -51 +51 @@
                 'position'                => 99,    // Index of where this nav item should be positioned.
                 'screen_function'         => false, // The name of the function to run when clicked.
-                'default_subnav_slug'     => false  // The slug of the default subnav item to select when clicked.
-        );
-
-        $r = wp_parse_args( $args, $defaults );
+                'default_subnav_slug'     => false, // The slug of the default subnav item to select when clicked.
+        );
+
+        $r = bp_parse_args(
+                $args,
+                $defaults
+        );
 
         // Validate nav link data.
@@ -131 +134 @@
         );
 
-        $r = wp_parse_args( $args, $defaults );
+        $r = bp_parse_args(
+                $args,
+                $defaults
+        );
 
         // If we don't have the required info we need, don't create this nav item.
@@ -218 +224 @@
         );
 
-        $r = wp_parse_args( $args, $defaults );
+        $r = bp_parse_args(
+                $args,
+                $defaults
+        );
 
         // If we don't have the required info we need, don't register this screen function.
@@ -315 +324 @@
         );
 
-        $r = wp_parse_args( $args, $defaults );
+        $r = bp_parse_args(
+                $args,
+                $defaults
+        );
 
         // This is specific to Members - it's not available in Groups.
@@ -530 +542 @@
         $bp = buddypress();
 
-        $r = wp_parse_args( $args, array(
-                'name'              => false, // Display name for the nav item.
-                'slug'              => false, // URL slug for the nav item.
-                'parent_slug'       => false, // URL slug of the parent nav item.
-                'parent_url'        => false, // URL of the parent item.
-                'item_css_id'       => false, // The CSS ID to apply to the HTML of the nav item.
-                'user_has_access'   => true,  // Can the logged in user see this nav item?
-                'no_access_url'     => '',
-                'site_admin_only'   => false, // Can only site admins see this nav item?
-                'position'          => 90,    // Index of where this nav item should be positioned.
-                'screen_function'   => false, // The name of the function to run when clicked.
-                'link'              => '',    // The link for the subnav item; optional, not usually required.
-                'show_in_admin_bar' => false, // Show the Manage link in the current group's "Edit" Admin Bar menu.
-        ) );
+        $r = bp_parse_args(
+                $args,
+                array(
+                        'name'              => false, // Display name for the nav item.
+                        'slug'              => false, // URL slug for the nav item.
+                        'parent_slug'       => false, // URL slug of the parent nav item.
+                        'parent_url'        => false, // URL of the parent item.
+                        'item_css_id'       => false, // The CSS ID to apply to the HTML of the nav item.
+                        'user_has_access'   => true,  // Can the logged in user see this nav item?
+                        'no_access_url'     => '',
+                        'site_admin_only'   => false, // Can only site admins see this nav item?
+                        'position'          => 90,    // Index of where this nav item should be positioned.
+                        'screen_function'   => false, // The name of the function to run when clicked.
+                        'link'              => '',    // The link for the subnav item; optional, not usually required.
+                        'show_in_admin_bar' => false, // Show the Manage link in the current group's "Edit" Admin Bar menu.
+                )
+        );
 
         // If we don't have the required info we need, don't create this subnav item.
@@ -626 +641 @@
         $bp = buddypress();
 
-        $r = wp_parse_args( $args, array(
-                'slug'              => false, // URL slug for the screen.
-                'parent_slug'       => false, // URL slug of the parent screen.
-                'user_has_access'   => true,  // Can the user visit this screen?
-                'no_access_url'     => '',
-                'site_admin_only'   => false, // Can only site admins visit this screen?
-                'screen_function'   => false, // The name of the function to run when clicked.
-        ) );
+        $r = bp_parse_args(
+                $args,
+                array(
+                        'slug'              => false, // URL slug for the screen.
+                        'parent_slug'       => false, // URL slug of the parent screen.
+                        'user_has_access'   => true,  // Can the user visit this screen?
+                        'no_access_url'     => '',
+                        'site_admin_only'   => false, // Can only site admins visit this screen?
+                        'screen_function'   => false, // The name of the function to run when clicked.
+                )
+        );
 
         /*