Changeset 13103 for trunk/tests/phpunit/testcases/groups/functions/get-group.php

Timestamp:

09/09/2021 02:01:40 PM (3 years ago)

Author:

espellcaste

Message:

Improving the group member count routine and the function helper.

The group member count routine was updated to avoid direct, uncached, SQL query and unnecessary cache refresh when a group's Members page was viewed.

is now being used to get the group member count which takes into account users' existence in the site,

the query is now cached and filterable.

was also updated to get the current group from if available.

Props imath
Fixes #7614 and see #6749

File:

• trunk/tests/phpunit/testcases/groups/functions/get-group.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/groups/functions/get-group.php

@@ -23 +23 @@
     }
 
+    /**
+     * @group bp_get_group
+     */
     public function test_bp_get_group_with_no_group() {
         $this->assertFalse( bp_get_group() );
@@ -28 +31 @@
     }
 
+    /**
+     * @group bp_get_group
+     */
     public function test_bp_get_group_with_id() {
         $g = $this->factory->group->create();
@@ -36 +42 @@
     }
 
+    /**
+     * @group bp_get_group
+     */
     public function test_bp_get_group_with_slug() {
         $slug = 'test-group';
@@ -50 +59 @@
     }
 
+    /**
+     * @group bp_get_group
+     */
     public function test_bp_get_group_with_object() {
         $g = $this->factory->group->create_and_get();
@@ -56 +68 @@
     }
 
+    /**
+     * @group bp_get_group
+     */
     public function test_bp_get_group_from_groups_template() {
         $g = $this->factory->group->create( array( 'status' => 'private' ) );
 
-        // Fake the current group.
-        $GLOBALS['groups_template'] = new stdClass;
-        $GLOBALS['groups_template']->group = groups_get_group( $g );
+        if ( bp_has_groups( array( 'include' => array( $g ) ) ) ) {
+            while ( bp_groups() ) {
+                bp_the_group();
+                $group = bp_get_group();
+            }
+        }
 
-        $this->assertSame( $g, bp_get_group()->id );
+        $this->assertSame( $g, $group->id );
+    }
+
+    /**
+     * @group bp_get_group
+     */
+    public function test_bp_get_group_from_current_group() {
+        $bp = buddypress();
+        $g  = $this->factory->group->create_and_get( array( 'name' => 'foo' ) );
+
+        // Set the current group.
+        $bp->groups->current_group = $g;
+
+        // Change the name to check the current group was used.
+        $bp->groups->current_group->name = 'bar';
+
+        // Override the name
+        do_action( 'bp_groups_set_current_group' );
+
+        $this->assertSame( 'bar', bp_get_group( $g->id )->name );
     }
 }