Changeset 13103 for trunk/tests/phpunit/testcases/groups/functions.php

Timestamp:

09/09/2021 02:01:40 PM (4 years ago)

Author:

espellcaste

Message:

Improving the group member count routine and the function helper.

The group member count routine was updated to avoid direct, uncached, SQL query and unnecessary cache refresh when a group's Members page was viewed.

is now being used to get the group member count which takes into account users' existence in the site,

the query is now cached and filterable.

was also updated to get the current group from if available.

Props imath
Fixes #7614 and see #6749

File:

• trunk/tests/phpunit/testcases/groups/functions.php (modified) (8 diffs)

trunk/tests/phpunit/testcases/groups/functions.php

@@ -185 +185 @@
 
         groups_join_group( $g, $u2 );
-        $this->assertEquals( 2, groups_get_groupmeta( $g, 'total_member_count' ) );
+        $this->assertEquals( 2, groups_get_total_member_count( $g ) );
+    }
+
+    /**
+     * @group total_member_count
+     */
+    public function test_total_member_count_with_invalid_group() {
+        $this->assertFalse( groups_get_total_member_count( 'invalid-group' ) );
+        $this->assertFalse( groups_get_total_member_count( '' ) );
+        $this->assertFalse( groups_get_total_member_count( 123456789 ) );
     }
 
@@ -194 +203 @@
     public function test_total_member_count_groups_leave_group() {
         $u1 = self::factory()->user->create();
+        $u2 = self::factory()->user->create();
         $g1 = self::factory()->group->create( array( 'creator_id' => $u1 ) );
-        groups_join_group( $g1, $u1 );
-
-        groups_leave_group( $g1, $u1 );
-        $this->assertEquals( 1, groups_get_groupmeta( $g1, 'total_member_count' ) );
+
+        groups_join_group( $g1, $u2 );
+
+        $this->assertEquals( 2, groups_get_total_member_count( $g1 ) );
+
+        groups_leave_group( $g1, $u2 );
+
+        $this->assertEquals( 1, groups_get_total_member_count( $g1 ) );
     }
 
@@ -215 +229 @@
         buddypress()->is_item_admin = true;
 
+        $this->assertEquals( 2, groups_get_total_member_count( $g1 ) );
+
         groups_ban_member( $u2, $g1 );
 
-        $this->assertEquals( 1, groups_get_groupmeta( $g1, 'total_member_count' ) );
+        $this->assertEquals( 1, groups_get_total_member_count( $g1 ) );
     }
 
@@ -236 +252 @@
         groups_ban_member( $u2, $g1 );
 
+        $this->assertEquals( 1, groups_get_total_member_count( $g1 ) );
+
         groups_unban_member( $u2, $g1 );
 
-        $this->assertEquals( 2, groups_get_groupmeta( $g1, 'total_member_count' ) );
+        $this->assertEquals( 2, groups_get_total_member_count( $g1 ) );
     }
 
@@ -256 +274 @@
         ) );
 
+        $this->assertEquals( 1, groups_get_total_member_count( $g ) );
+
         groups_accept_invite( $u2, $g );
 
-        $this->assertEquals( 2, groups_get_groupmeta( $g, 'total_member_count' ) );
+        $this->assertEquals( 2, groups_get_total_member_count( $g ) );
     }
 
@@ -276 +296 @@
         groups_accept_membership_request( 0, $u2, $g );
 
-        $this->assertEquals( 2, groups_get_groupmeta( $g, 'total_member_count' ) );
+        $this->assertEquals( 2, groups_get_total_member_count( $g ) );
     }
 
@@ -295 +315 @@
         groups_remove_member( $u2, $g1 );
 
-        $this->assertEquals( 1, groups_get_groupmeta( $g1, 'total_member_count' ) );
+        $this->assertEquals( 1, groups_get_total_member_count( $g1 ));
+    }
+
+    /**
+     * @group total_member_count
+     * @group groups_remove_member
+     */
+    public function test_total_member_count_groups_delete_member() {
+        $u1 = self::factory()->user->create();
+        $u2 = self::factory()->user->create();
+        $u3 = self::factory()->user->create();
+        $g1 = self::factory()->group->create( array( 'creator_id' => $u1 ) );
+
+        groups_join_group( $g1, $u2 );
+        groups_join_group( $g1, $u3 );
+
+        $this->assertEquals( 3, groups_get_total_member_count( $g1 ) );
+        $this->assertEquals( 3, BP_Groups_Group::get_total_member_count( $g1 ) );
+
+        add_filter( 'bp_remove_user_data_on_delete_user_hook', '__return_true' );
+
+        // Delete user.
+        wp_delete_user( $u2 );
+
+        remove_filter( 'bp_remove_user_data_on_delete_user_hook', '__return_true' );
+
+        $this->assertEquals( 2, groups_get_total_member_count( $g1 ) );
+        $this->assertEquals( 2, BP_Groups_Group::get_total_member_count( $g1 ) );
     }
 
@@ -314 +361 @@
         ) );
 
-        $this->assertEquals( 1, groups_get_groupmeta( $g, 'total_member_count' ) );
+        $this->assertEquals( 1, groups_get_total_member_count( $g ) );
     }