Changeset 13100

Timestamp:

09/01/2021 07:00:37 PM (5 years ago)

Author:

imath

Message:

Media: improve Cover Image UI feedbacks when an image is uploaded

Instead of only informing the uploaded image is smaller than the recommended size, the UI will now also inform the image has been successfully uploaded in such a case.

Props mandro

Fixes #8563

File:

• trunk/src/bp-core/js/cover-image.js (modified) (1 diff)

trunk/src/bp-core/js/cover-image.js

@@ -194 +194 @@
 
                 uploadResult: function( model ) {
-                        var message, type;
+                        var feedbackCode, feedbackViews = [];
 
                         if ( ! _.isUndefined( model.get( 'url' ) ) ) {
+                                feedbackCode = model.get( 'feedback_code' );
 
                                 // Image is too small.
-                                if ( 0 === model.get( 'feedback_code' ) ) {
-                                        message = BP_Uploader.strings.cover_image_warnings.dimensions;
-                                        type    = 'warning';
+                                if ( 0 === feedbackCode ) {
+                                        feedbackCode = 1;
+                                        feedbackViews.push(
+                                                new bp.Views.CoverImageStatus( {
+                                                        value : BP_Uploader.strings.cover_image_warnings.dimensions,
+                                                        type  : 'warning'
+                                                } )
+                                        );
+                                }
+
+                                feedbackViews.unshift(
+                                        new bp.Views.CoverImageStatus( {
+                                                value : BP_Uploader.strings.feedback_messages[ feedbackCode ],
+                                                type  : 'success'
+                                        } )
+                                );
 
                                 // Success, Rock n roll!
-                                } else {
-                                        message = BP_Uploader.strings.feedback_messages[ model.get( 'feedback_code' ) ];
-                                        type = 'success';
-                                }
-
-                                this.views.set( '.bp-uploader-progress', new bp.Views.CoverImageStatus( {
-                                        value : message,
-                                        type  : type
-                                } ) );
+                                this.views.set( '.bp-uploader-progress', feedbackViews );
 
                                 // Update the header of the page.