Changeset 13086 for trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

Timestamp:

08/22/2021 03:16:06 AM (3 years ago)

Author:

espellcaste

Message:

Marking deprecated query classes, their methods, arguments as deprecated in the BP_Friends_Friendship and BP_Friends_Friendship classes.

Props imath

Fixes #8554 (trunk)

File:

• trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -16 +16 @@
     }
 
+    /**
+     * @group __construct
+     * @expectedDeprecated BP_Groups_Group::__construct
+     */
+    public function test_deprecated_arg() {
+        $group = new BP_Groups_Group( 123456789, array( 'populate_extras' => true ) );
+        $this->assertSame( 0, $group->id );
+    }
+
     /** get() ************************************************************/
+
+    /**
+     * @group get
+     */
+    public function test_get_group_id_with_slug() {
+        $slug     = 'group-test';
+        $g1       = self::factory()->group->create( array( 'slug' => $slug ) );
+        $group_id = BP_Groups_Group::group_exists( $slug );
+
+        $this->assertSame( $g1, $group_id );
+    }
+
+    /**
+     * @group get
+     */
+    public function test_get_group_id_with_empty_slug() {
+        $this->assertFalse( BP_Groups_Group::group_exists( '' ) );
+    }
+
+    /**
+     * @group get
+     */
+    public function test_get_group_id_from_slug_with_empty_slug() {
+        $this->assertFalse( BP_Groups_Group::get_id_from_slug( '' ) );
+    }
+
+    /**
+     * @group get
+     */
+    public function test_get_group_id_from_slug() {
+        $slug     = 'group-test';
+        $g1       = self::factory()->group->create( array( 'slug' => $slug ) );
+        $group_id = BP_Groups_Group::get_id_from_slug( $slug );
+
+        $this->assertSame( $g1, $group_id );
+    }
+
+    /**
+     * @group get
+     * @expectedDeprecated BP_Groups_Group::group_exists
+     */
+    public function test_get_group_with_slug_with_deprecated_args() {
+        $slug     = 'group-test';
+        $g1       = self::factory()->group->create( array( 'slug' => $slug ) );
+        $group_id = BP_Groups_Group::group_exists( $slug, 'random-name' );
+
+        $this->assertSame( $g1, $group_id );
+    }
 
     /**
@@ -1144 +1201 @@
 
         $groups = BP_Groups_Group::search_groups( "'tis " );
-
-        $found = wp_list_pluck( $groups['groups'], 'group_id' );
+        $found  = wp_list_pluck( $groups['groups'], 'group_id' );
 
         $this->assertEquals( array( $g1 ), $found );
+        $this->assertNotContains( $g2, $found );
+    }
+
+    /**
+     * @expectedDeprecated BP_Groups_Group::get_by_letter
+     */
+    public function test_get_by_letter_with_deprecated_arg() {
+        $g1 = self::factory()->group->create( array(
+            'name'        => 'Awesome Cool Group',
+            'description' => 'Neat',
+        ) );
+        $g2 = self::factory()->group->create();
+
+        $groups = BP_Groups_Group::get_by_letter( 'A', null, null, false );
+        $found  = wp_list_pluck( $groups['groups'], 'id' );
+
+        $this->assertEquals( array( $g1 ), $found );
+        $this->assertNotContains( $g2, $found );
     }
 
     public function test_get_by_letter_typical_use() {
+        $g1 = self::factory()->group->create( array(
+            'name'        => 'Awesome Cool Group',
+            'description' => 'Neat',
+        ) );
+        $g2 = self::factory()->group->create();
+
+        $groups = BP_Groups_Group::get_by_letter( 'A' );
+        $found  = wp_list_pluck( $groups['groups'], 'id' );
+
+        $this->assertEquals( array( $g1 ), $found );
+        $this->assertNotContains( $g2, $found );
+    }
+
+    public function test_get_by_letter_with_exclude() {
         $g1 = self::factory()->group->create( array(
             'name' => 'Awesome Cool Group',
@@ -1156 +1244 @@
         ) );
         $g2 = self::factory()->group->create( array(
-            'name' => 'Babylon Kong',
-            'description' => 'Awesome',
-        ) );
-
-        $groups = BP_Groups_Group::get_by_letter( 'A' );
-
-        $found = wp_list_pluck( $groups['groups'], 'id' );
-
-        $this->assertEquals( array( $g1 ), $found );
-
-    }
-
-    public function test_get_by_letter_with_exclude() {
-        $g1 = self::factory()->group->create( array(
-            'name' => 'Awesome Cool Group',
-            'description' => 'Neat',
-        ) );
-        $g2 = self::factory()->group->create( array(
             'name' => 'Another Cool Group',
             'description' => 'Awesome',
@@ -1179 +1249 @@
 
         $groups = BP_Groups_Group::get_by_letter( 'A', null, null, true, array( $g1, 'stringthatshouldberemoved' ) );
-
-        $found = wp_list_pluck( $groups['groups'], 'id' );
+        $found  = wp_list_pluck( $groups['groups'], 'id' );
 
         $this->assertEquals( array( $g2 ), $found );
@@ -1210 +1279 @@
     }
 
+    /**
+     * @expectedDeprecated BP_Groups_Group::get_random
+     */
+    public function test_get_random_with_deprecated_arg() {
+        $g1 = self::factory()->group->create();
+        $g2 = self::factory()->group->create();
+
+        // There are only two groups, so excluding one should give us the other
+        $groups = BP_Groups_Group::get_random( null, null, 0, false, false, array( $g1, 'ignore this' ) );
+        $found  = wp_list_pluck( $groups['groups'], 'id' );
+
+        $this->assertEquals( array( $g2 ), $found );
+    }
+
     public function test_get_random_with_exclude() {
         $g1 = self::factory()->group->create();
@@ -1232 +1315 @@
         // Only one group will match, so the random part doesn't matter
         $groups = BP_Groups_Group::get_random( null, null, 0, 'daci' );
-
-        $found = wp_list_pluck( $groups['groups'], 'id' );
+        $found  = wp_list_pluck( $groups['groups'], 'id' );
 
         $this->assertEquals( array( $g1 ), $found );
+        $this->assertNotContains( $g2, $found );
     }