Changeset 13020

Timestamp:

07/17/2021 10:55:24 AM (4 years ago)

Author:

imath

Message:

Groups Block: the avatar URL is the src attribute of the img tag

The alt attribut was wrongly used & the alternative text for the image was used into the src attribute. Let's make sure everything goes at the right place.

NB: this commit also improve escaping for the alt attribute of the Group Block.

Fixes #8531

File:

• trunk/src/bp-groups/bp-groups-blocks.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-blocks.php

@@ -94 +94 @@
             esc_url( $avatar ),
             /* Translators: %s is the group's name. */
-            sprintf( esc_html__( 'Group Profile photo of %s', 'buddypress' ), $group_name )
+            sprintf( esc_attr__( 'Group Profile photo of %s', 'buddypress' ), esc_html( $group_name ) )
         );
     }
@@ -246 +246 @@
                 </div>',
                 esc_url( $group_link ),
-                /* Translators: %s is the group's name. */
-                sprintf( esc_attr__( 'Group Profile photo of %s', 'buddypress' ), esc_html( $group->name ) ),
                 esc_url(
                     bp_core_fetch_avatar(
@@ -257 +255 @@
                         )
                     )
-                )
+                ),
+                /* Translators: %s is the group's name. */
+                sprintf( esc_attr__( 'Group Profile photo of %s', 'buddypress' ), esc_html( $group->name ) )
             );
         }