Changeset 13014

Timestamp:

07/15/2021 11:44:42 AM (4 years ago)

Author:

imath

Message:

Ensure the href attribute is not wrongly used inside button elements

Props sbrajesh

Fixes #8498

File:

• trunk/src/bp-core/classes/class-bp-button.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-button.php

@@ -325 +325 @@
         $button = '';
         if ( ! empty( $r['button_element'] ) ) {
+            // Ensure the `href` attribute is not wrongly used inside buttons.
+            if ( 'button' === $r['button_element'] && ! empty( $r['button_attr']['href'] ) ) {
+                _doing_it_wrong(
+                    __CLASS__,
+                    __( 'The `href` attribute is not available inside the `<button>` tag. Please use a `data-*` attribute to transport a link into this tag.', 'buddypress' ),
+                    '9.0.0'
+                );
+
+                unset( $r['button_attr']['href'] );
+            }
+
             $button = new BP_Core_HTML_Element( array(
                 'element'    => $r['button_element'],