Changeset 12994 for trunk/src/bp-core/classes/class-bp-component.php

Timestamp:

07/12/2021 07:48:13 PM (5 years ago)

Author:

imath

Message:

Make sure all BP components init their BP Blocks

Even if some components don't have native BP Blocks, it makes it easier for developers to add their custom blocks or override existing BP Blocks or disable BP Blocks. Working on the BP Blocks feature as a plugin made us realize this.

This commit also improves the BP_Block constructor inline documentation, adds a new method to the Core component to register REST controllers and moves the BP_REST_Components_Endpoint one from the Members component to the Core component.

Fixes #8511

File:

• trunk/src/bp-core/classes/class-bp-component.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-component.php

@@ -918 +918 @@
      * @since 6.0.0
      *
+     * @see `BP_Block->construct()` for a full description of a BP Block arguments.
+     *
      * @param array $blocks The list of BP Blocks to register.
      */
     public function blocks_init( $blocks = array() ) {
-        if ( is_array( $blocks ) && $blocks ) {
-            /**
-             * Filter here to disable all or some BP Blocks for a component.
-             *
-             * This is a dynamic hook that is based on the component string ID.
-             *
-             * @since 6.0.0
-             *
-             * @param array $blocks The list of BP Blocks for the component.
-             */
-            $blocks = (array) apply_filters( 'bp_' . $this->id . '_register_blocks', $blocks );
-
+        /**
+         * Filter here to add new BP Blocks, disable some or all BP Blocks for a component.
+         *
+         * This is a dynamic hook that is based on the component string ID.
+         *
+         * @since 6.0.0
+         *
+         * @param array $blocks The list of BP Blocks for the component.
+         */
+        $blocks = (array) apply_filters( 'bp_' . $this->id . '_register_blocks', $blocks );
+        $blocks = array_filter( $blocks );
+
+        if ( $blocks ) {
             foreach ( $blocks as $block ) {
                 bp_register_block( $block );