Changeset 12948 for trunk/src/bp-core/admin/bp-core-admin-slugs.php

Timestamp:

05/13/2021 08:26:05 AM (5 years ago)

Author:

imath

Message:

BP Settings: remove links to view Register and Activate pages

As these pages can only be reached by logged out users, to avoid to confuse Admins we're replacing the links with a message to inform them they need to log out to view these pages.

Fixes #8475

File:

• trunk/src/bp-core/admin/bp-core-admin-slugs.php (modified) (7 diffs)

trunk/src/bp-core/admin/bp-core-admin-slugs.php

@@ -118 +118 @@
     $directory_pages = bp_core_admin_get_directory_pages();
 
-    if ( !empty( $directory_pages ) ) : ?>
-
-        <h3><?php _e( 'Directories', 'buddypress' ); ?></h3>
-
-        <p><?php _e( 'Associate a WordPress Page with each BuddyPress component directory.', 'buddypress' ); ?></p>
+    if ( ! empty( $directory_pages ) ) : ?>
+
+        <h3><?php esc_html_e( 'Directories', 'buddypress' ); ?></h3>
+
+        <p><?php esc_html_e( 'Associate a WordPress Page with each BuddyPress component directory.', 'buddypress' ); ?></p>
 
         <table class="form-table">
@@ -142 +142 @@
                                 'echo'             => false,
                                 'show_option_none' => __( '- None -', 'buddypress' ),
-                                'selected'         => !empty( $existing_pages[$name] ) ? $existing_pages[$name] : false
+                                'selected'         => ! empty( $existing_pages[$name] ) ? $existing_pages[$name] : false
                             ) ); ?>
 
@@ -148 +148 @@
 
                                 <a href="<?php echo esc_url( get_permalink( $existing_pages[$name] ) ); ?>" class="button-secondary" target="_bp">
-                                    <?php _e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external" aria-hidden="true"></span>
+                                    <?php esc_html_e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external" aria-hidden="true"></span>
                                     <span class="screen-reader-text"><?php esc_html_e( '(opens in a new tab)', 'buddypress' ); ?></span>
                                 </a>
@@ -186 +186 @@
     if ( !empty( $static_pages ) ) : ?>
 
-        <h3><?php _e( 'Registration', 'buddypress' ); ?></h3>
+        <h3><?php esc_html_e( 'Registration', 'buddypress' ); ?></h3>
 
         <?php if ( bp_get_signup_allowed() || bp_get_members_invitations_allowed() ) : ?>
-            <p><?php _e( 'Associate WordPress Pages with the following BuddyPress Registration pages.', 'buddypress' ); ?></p>
+            <p>
+                <?php esc_html_e( 'Associate WordPress Pages with the following BuddyPress Registration pages.', 'buddypress' ); ?>
+                <?php esc_html_e( 'These pages will only be reachable by users who are not logged in.', 'buddypress' ); ?>
+            </p>
         <?php else : ?>
             <?php if ( is_multisite() ) : ?>
                 <p>
                     <?php
-                    /* translators: %s: the link to the Network settings page */
-                    printf( __( 'Registration is currently disabled.  Before associating a page is allowed, please enable registration by selecting either the "User accounts may be registered" or "Both sites and user accounts can be registered" option on <a href="%s">this page</a>.', 'buddypress' ), network_admin_url( 'settings.php' ) );
+                    printf(
+                        /* translators: %s: the link to the Network settings page */
+                        esc_html_x( 'Registration is currently disabled.  Before associating a page is allowed, please enable registration by selecting either the "User accounts may be registered" or "Both sites and user accounts can be registered" option on %s.', 'Disabled registration message for multisite config', 'buddypress' ),
+                        sprintf(
+                            '<a href="%1$s">%2$s</a>',
+                            esc_url( network_admin_url( 'settings.php' ) ),
+                            esc_html_x( 'this page', 'Link text for the Multisite’s network settings page', 'buddypress' )
+                        )
+                    );
                     ?>
                 </p>
@@ -201 +211 @@
                 <p>
                     <?php
-                    /* translators: %s: the link to the Site settings page */
-                    printf( __( 'Registration is currently disabled.  Before associating a page is allowed, please enable registration by clicking on the "Anyone can register" checkbox on <a href="%s">this page</a>.', 'buddypress' ), admin_url( 'options-general.php' ) );
+                    printf(
+                        /* translators: %s: the link to the Site general options page */
+                        esc_html_x( 'Registration is currently disabled.  Before associating a page is allowed, please enable registration by clicking on the "Anyone can register" checkbox on %s.', 'Disabled registration message for regular site config', 'buddypress' ),
+                        sprintf(
+                            '<a href="%1$s">%2$s</a>',
+                            esc_url( admin_url( 'options-general.php' ) ),
+                            esc_html_x( 'this page', 'Link text for the Site’s general options page', 'buddypress' )
+                        )
+                    );
                     ?>
                 </p>
@@ -229 +246 @@
                             ) ) ?>
 
-                            <?php if ( ! empty( $existing_pages[ $name ] ) && get_post( $existing_pages[ $name ] ) ) : ?>
-
-                                <a href="<?php echo get_permalink( $existing_pages[$name] ); ?>" class="button-secondary" target="_bp"><?php _e( 'View', 'buddypress' ); ?></a>
-
-                            <?php endif; ?>
-
                             <?php if ( ! bp_is_root_blog() ) restore_current_blog(); ?>
 
@@ -267 +278 @@
 
     if ( isset( $_POST['bp-admin-pages-submit'] ) ) {
-        if ( !check_admin_referer( 'bp-admin-pages-setup' ) )
+        if ( ! check_admin_referer( 'bp-admin-pages-setup' ) ) {
             return false;
+        }
 
         // Then, update the directory pages.