Changeset 12932 for trunk/src/bp-core/classes/class-bp-email.php

Timestamp:

04/29/2021 01:28:50 PM (4 years ago)

Author:

imath

Message:

BP Email: introduce "unnamed" salutation

The member invites feature's goal is to invite external users to join a community. The BP Email feature uses a named salutation by default. As a result, the salutation of invitation emails was "Hi email@…,". The user's name is not yet known and using this kind of salutation is odd. The member invites feature's need is to simply use an "unnamed" salutation eg: "Hi,". To satisfy it we are updating the BP Email type schema with a new property $named_salutation which defaults to true. If this property is false, then the sent email will from now on use an unnamed salutation.

NB: to prevent potential back compatibiliy issues, each kind of salutation has their own filters

• Use bp_email_get_unnamed_salutation to edit the unnamed one.
• Use bp_email_get_salutation to edit the default one (named).

Props dcavins for coloring outside the lines a bit 😉

See #8139

File:

• trunk/src/bp-core/classes/class-bp-email.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-email.php

@@ -791 +791 @@
             add_filter( 'bp_locate_template_and_load', '__return_true' );
 
+            // Set up the `$post` global.
+            global $post;
+            $reset_post = $post;
+            $post       = $this->post_object;
+
             bp_locate_template( bp_email_get_template( $this->post_object ), true, false );
+
+            // Reset the `$post` global.
+            $post = $reset_post;
 
             remove_filter( 'bp_locate_template_and_load', '__return_true' );