Changeset 12930 for trunk/src/bp-members/classes/class-bp-members-invitations-list-table.php

Timestamp:

04/29/2021 08:31:02 AM (5 years ago)

Author:

imath

Message:

Member Invites: add missing /* translators: */ inline comments

This commit also:

• adds some tiny improvements to get along with WP Coding Standards,
• removes a forgotten PHP notice using the right $args variable instead of the undefined $all_args one in bp_members_invitations_get_registration_welcome_message()
• removes an extra <hr class="wp-header-end"> into the Manage Invitations Admin screen that was causing admin notices to appear twice.
• Uses the wpautop() function instead of an inexisting wpautop filter into bp_members_invitations_add_legacy_welcome_message() and bp_members_invitations_add_legacy_registration_disabled_message().

Huge Props dcavins for this awesome new feature!

See #8139

File:

• trunk/src/bp-members/classes/class-bp-members-invitations-list-table.php (modified) (5 diffs)

trunk/src/bp-members/classes/class-bp-members-invitations-list-table.php

@@ -67 +67 @@
 
                 $args = array(
-                        'invite_sent'       => 'all',
-                        'accepted'          => 'all',
-                        'search_terms'      => $search,
-                        'order_by'          => 'date_modified',
-                        'sort_order'        => 'DESC',
-                        'page'              => $paged,
-                        'per_page'          => $per_page,
+                        'invite_sent'  => 'all',
+                        'accepted'     => 'all',
+                        'search_terms' => $search,
+                        'order_by'     => 'date_modified',
+                        'sort_order'   => 'DESC',
+                        'page'         => $paged,
+                        'per_page'     => $per_page,
                 );
 
@@ -123 +123 @@
                 ?>
 
-                <h2 class="screen-reader-text"><?php
+                <h2 class="screen-reader-text">
+                        <?php
                         /* translators: accessibility text */
                         esc_html_e( 'Filter invitations list', 'buddypress' );
-                ?></h2>
+                        ?>
+                </h2>
                 <ul class="subsubsub">
                         <li class="all">
@@ -199 +201 @@
                  * @param array $value Array of columns to display.
                  */
-                return apply_filters( 'bp_members_invitations_list_columns', array(
-                        'cb'                       => '<input type="checkbox" />',
-                        'invitee_email'            => __( 'Invitee', 'buddypress' ),
-                        'username'                 => __( 'Inviter', 'buddypress' ),
-                        'inviter_registered_date'  => __( 'Inviter Registered', 'buddypress' ),
-                        'invitation_date_modified' => __( 'Date Modified', 'buddypress' ),
-                        'invitation_sent'          => __( 'Email Sent', 'buddypress' ),
-                        'invitation_accepted'      => __( 'Accepted', 'buddypress' )
-                ) );
+                return apply_filters(
+                        'bp_members_invitations_list_columns',
+                        array(
+                                'cb'                       => '<input type="checkbox" />',
+                                'invitee_email'            => __( 'Invitee', 'buddypress' ),
+                                'username'                 => __( 'Inviter', 'buddypress' ),
+                                'inviter_registered_date'  => __( 'Inviter Registered', 'buddypress' ),
+                                'invitation_date_modified' => __( 'Date Modified', 'buddypress' ),
+                                'invitation_sent'          => __( 'Email Sent', 'buddypress' ),
+                                'invitation_accepted'      => __( 'Accepted', 'buddypress' )
+                        )
+                );
         }
 
@@ -239 +244 @@
                         esc_html_e( 'No invitations found.', 'buddypress' );
                 } else {
-                        $link = sprintf( '<a href="%1$s">%2$s</a>', esc_url( bp_get_admin_url( add_query_arg( array( 'page' => 'bp-settings' ), 'admin.php' ) ) ), esc_html__( 'Edit settings', 'buddypress' ) );
+                        $link = sprintf(
+                                '<a href="%1$s">%2$s</a>',
+                                esc_url( bp_get_admin_url( add_query_arg( array( 'page' => 'bp-settings' ), 'admin.php' ) ) ),
+                                esc_html__( 'Edit settings', 'buddypress' )
+                        );
 
                         /* translators: %s: url to site settings */
@@ -302 +311 @@
          */
         public function column_cb( $invite = null ) {
-        ?>
-                <label class="screen-reader-text" for="invitation_<?php echo intval( $invite->id ); ?>"><?php
-                        /* translators: accessibility text */
-                        printf( esc_html__( 'Select invitation: %s', 'buddypress' ), $invite->id );
-                ?></label>
+                ?>
+                <label class="screen-reader-text" for="invitation_<?php echo intval( $invite->id ); ?>">
+                        <?php
+                                /* translators: accessibility text */
+                                printf( esc_html__( 'Select invitation: %s', 'buddypress' ), $invite->id );
+                        ?>
+                </label>
                 <input type="checkbox" id="invitation_<?php echo intval( $invite->id ) ?>" name="invite_ids[]" value="<?php echo esc_attr( $invite->id ) ?>" />
                 <?php