Changeset 12892 for trunk/src/bp-members/bp-members-template.php

Timestamp:

04/18/2021 10:18:06 AM (5 years ago)

Author:

imath

Message:

Nouveau: improve the way customizable slugs are handled

BuddyPress uses constants such as BP_FRIENDS_SLUG to let advanced users customize component URL slugs. The Nouveau template pack was wrongly checking hardcoded component names at various places into its code, in particular into the following functions and template tags:

• bp_nouveau_current_object()
• bp_nouveau_filter_options()
• bp_nouveau_wrapper()

This commit also introduces a new BP Core function to get the active BP Component objects: bp_core_get_active_components(). The $args argument can be used to filter the active components according to their slugs, names, ids or root slugs. Nouveau uses it to determine the component ID out of its slug and use this component ID instead of slugs to create its needed dynamic selectors, classes and data attributes.

Props mattneil

Fixes #8133

File:

• trunk/src/bp-members/bp-members-template.php (modified) (2 diffs)

trunk/src/bp-members/bp-members-template.php

@@ -2801 +2801 @@
          */
         function bp_get_members_component_link( $component, $action = '', $query_args = '', $nonce = false ) {
-
                 // Must be displayed user.
-                if ( !bp_displayed_user_id() )
+                if ( ! bp_displayed_user_id() ) {
                         return;
+                }
 
                 $bp = buddypress();
 
+                if ( 'xprofile' === $component ) {
+                        $component = 'profile';
+                }
+
                 // Append $action to $url if there is no $type.
-                if ( !empty( $action ) )
+                if ( ! empty( $action ) ) {
                         $url = bp_displayed_user_domain() . $bp->{$component}->slug . '/' . $action;
-                else
+                } else {
                         $url = bp_displayed_user_domain() . $bp->{$component}->slug;
+                }
 
                 // Add a slash at the end of our user url.
@@ -2818 +2823 @@
 
                 // Add possible query arg.
-                if ( !empty( $query_args ) && is_array( $query_args ) )
+                if ( ! empty( $query_args ) && is_array( $query_args ) ) {
                         $url = add_query_arg( $query_args, $url );
+                }
 
                 // To nonce, or not to nonce...
-                if ( true === $nonce )
+                if ( true === $nonce ) {
                         $url = wp_nonce_url( $url );
-                elseif ( is_string( $nonce ) )
+                } elseif ( is_string( $nonce ) ) {
                         $url = wp_nonce_url( $url, $nonce );
+                }
 
                 // Return the url, if there is one.
-                if ( !empty( $url ) )
+                if ( ! empty( $url ) ) {
                         return $url;
+                }
         }