Changeset 12887 for trunk/src/bp-templates/bp-nouveau/includes/xprofile/template-tags.php

Timestamp:

04/16/2021 05:37:03 AM (5 years ago)

Author:

imath

Message:

Update both Template Pack registration forms to use signup fields

• Nouveau and Legacy are now usinf the bp_xprofile_signup_args() to build the argument of their registration's form xProfile loop.
• Include a backward compatibility mechanism if the register.php page has been overriden from a theme or a plugin.
• This commit also includes PHP Unit tests about the xProfile loop and Signup Fields.

Props johnjamesjacoby, boonebgorges, DJPaul, Offereins

Fixes #6347

File:

• trunk/src/bp-templates/bp-nouveau/includes/xprofile/template-tags.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/includes/xprofile/template-tags.php

@@ -4 +4 @@
  *
  * @since 3.0.0
- * @version 3.0.0
+ * @version 8.0.0
  */
 
@@ -63 +63 @@
  *
  * @since 3.0.0
+ * @deprecated 8.0.0
  */
 function bp_nouveau_base_account_has_xprofile() {
-    return (bool) bp_has_profile(
-        array(
-            'profile_group_id' => 1,
-            'fetch_field_data' => false,
-        )
-    );
+    _deprecated_function( __FUNCTION__, '8.0.0', 'bp_nouveau_has_signup_xprofile_fields()' );
+    return bp_nouveau_has_signup_xprofile_fields();
 }
+
+/**
+ * Checks whether there are signup profile fields to display.
+ *
+ * @since 8.0.0
+ *
+ * @param bool Whether to init an xProfile loop.
+ * @return bool True if there are signup profile fields to display. False otherwise.
+ */
+function bp_nouveau_has_signup_xprofile_fields( $do_loop = false ) {
+    if ( ! $do_loop ) {
+        $signup_fields = (array) bp_xprofile_get_signup_field_ids();
+        return 1 <= count( $signup_fields );
+    }
+
+    return bp_has_profile( bp_xprofile_signup_args() );
+}