Changeset 12881 for trunk/src/bp-xprofile/bp-xprofile-admin.php

Timestamp:

04/13/2021 04:16:04 AM (4 years ago)

Author:

imath

Message:

xProfile: make sure a Field Type can enforce field visibility

When saving a field having a Field Type where the custom visibility feature is disabled and the visibility property is set, use this visibility to enforce the field visibility. This part was forgotten in #7162 and it is needed by the Checkbox Acceptance field to make sure only the logged in user can see they agreed to the page requiring their acceptance.

Props mahdiar, vapvarun

See #4747

File:

• trunk/src/bp-xprofile/bp-xprofile-admin.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-admin.php

@@ -558 +558 @@
 
                     if ( ! $field->field_type_supports( 'allow_custom_visibility' ) ) {
-                        $default_visibility = 'public';
+                        $default_visibility          = 'public';
+                        $available_visibility_levels = bp_xprofile_get_visibility_levels();
+
+                        if ( isset( $field->type_obj->visibility ) && in_array( $field->type_obj->visibility, array_keys( $available_visibility_levels ), true ) ) {
+                            $default_visibility = $field->type_obj->visibility;
+                        }
                     }