Changeset 12780

Timestamp:

11/11/2020 06:11:10 PM (3 years ago)

Author:

imath

Message:

Prevent a PHP 8.0 deprecated notice about optional function argument

The bp_admin_get_wp_nav_menu_items() funciton was introduced in 7.0.0 to fix an issue with the BuddyPress Members WP Nav Menu items. It was wrongly using an optional argument before a required one. As PHP 8.0 no longer accepts this practice, both arguments of the function will be required 😇.

Fixes #8390

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (1 diff)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -771 +771 @@
  * @return array   The BP Member nav items to short-circuit WP's query,
  */
-function bp_admin_get_wp_nav_menu_items( $null = null, $wp_query ) {
+function bp_admin_get_wp_nav_menu_items( $null, $wp_query ) {
     if ( isset( $wp_query->query['orderby'], $wp_query->query['order'] ) && 'post_date' === $wp_query->query['orderby'] && 'DESC' === $wp_query->query['order'] ) {
         return bp_nav_menu_get_loggedin_pages();