Changeset 12776 for trunk/src/bp-members/bp-members-functions.php

Timestamp:

11/09/2020 02:47:32 AM (4 years ago)

Author:

johnjamesjacoby

Message:

Group/Member Types: More string changes.

This commit includes the following code changes:

• Change case of strings to match how WordPress core labels are cased
• Reorder schema so singular is before plural (see: order of adjectives)
• Adds missing taxonomy labels for core functionalities that could be activated or used later (hierarchy, popularity, etc...)
• Simplifies all verbiage, to be more concise without sacrificing accuracy or descriptiveness (removes example URLs, encoded quotes, etc...)
• Remove "member" references from default strings, and re-add them back in using member-specific variants to match how groups works
• Related inline documentation

Together, these changes bring both Group and Member types closer in readability and usability to other taxonomies, making them feel a little bit more familiar, while also keeping strings within 2 lines tall on most viewport sizes, and hopefully making them easier to understand for users who are new to these features.

See #7179, #7181.

File:

• trunk/src/bp-members/bp-members-functions.php (modified) (3 diffs)

trunk/src/bp-members/bp-members-functions.php

@@ -2690 +2690 @@
         'bp_get_member_type_tax_labels',
         array(
-            'name'                       => _x( 'Member types', 'Member type taxonomy name', 'buddypress' ),
-            'singular_name'              => _x( 'Member type', 'Member type taxonomy singular name', 'buddypress' ),
-            'search_items'               => _x( 'Search Member types', 'Member type taxonomy search items label', 'buddypress' ),
-            'popular_items'              => _x( 'Most used Member types', 'Member type taxonomy popular items label', 'buddypress' ),
-            'all_items'                  => _x( 'All Member types', 'Member type taxonomy all items label', 'buddypress' ),
-            'edit_item'                  => _x( 'Edit Member type', 'Member type taxonomy edit item label', 'buddypress' ),
-            'view_item'                  => _x( 'View Member type', 'Member type taxonomy view item label', 'buddypress' ),
-            'update_item'                => _x( 'Update Member type', 'Member type taxonomy update item label', 'buddypress' ),
-            'add_new_item'               => _x( 'Add new Member type', 'Member type taxonomy add new item label', 'buddypress' ),
-            'new_item_name'              => _x( 'New Member type name', 'Member type taxonomy new item name label', 'buddypress' ),
-            'separate_items_with_commas' => _x( 'Separate Member types with commas', 'Member type taxonomy separate items with commas label', 'buddypress' ),
-            'add_or_remove_items'        => _x( 'Add or remove Member types', 'Member type taxonomy add or remove items label', 'buddypress' ),
-            'choose_from_most_used'      => _x( 'Choose from the most used Member types', 'Member type taxonomy choose from most used label', 'buddypress' ),
-            'not_found'                  => _x( 'No Member types found', 'Member type taxonomy not found label', 'buddypress' ),
-            'no_terms'                   => _x( 'No Member types', 'Member type taxonomy no terms label', 'buddypress' ),
-            'items_list_navigation'      => _x( 'Member types list navigation', 'Member type taxonomy items list navigation label', 'buddypress' ),
-            'items_list'                 => _x( 'Member types list', 'Member type taxonomy items list label', 'buddypress' ),
-            'back_to_items'              => _x( 'Back to all Member types', 'Member type taxonomy back to items label', 'buddypress' ),
+
+            // General labels
+            'name'                       => _x( 'Member Types', 'Member type taxonomy name', 'buddypress' ),
+            'singular_name'              => _x( 'Member Type', 'Member type taxonomy singular name', 'buddypress' ),
+            'search_items'               => _x( 'Search Member Types', 'Member type taxonomy search items label', 'buddypress' ),
+            'popular_items'              => _x( 'Popular Member Types', 'Member type taxonomy popular items label', 'buddypress' ),
+            'all_items'                  => _x( 'All Member Types', 'Member type taxonomy all items label', 'buddypress' ),
+            'parent_item'                => _x( 'Parent Member Type', 'Member type taxonomy parent item label', 'buddypress' ),
+            'parent_item_colon'          => _x( 'Parent Member Type:', 'Member type taxonomy parent item label', 'buddypress' ),
+            'edit_item'                  => _x( 'Edit Member Type', 'Member type taxonomy edit item label', 'buddypress' ),
+            'view_item'                  => _x( 'View Member Type', 'Member type taxonomy view item label', 'buddypress' ),
+            'update_item'                => _x( 'Update Member Type', 'Member type taxonomy update item label', 'buddypress' ),
+            'add_new_item'               => _x( 'Add New Member Type', 'Member type taxonomy add new item label', 'buddypress' ),
+            'new_item_name'              => _x( 'New Member Type Name', 'Member type taxonomy new item name label', 'buddypress' ),
+            'separate_items_with_commas' => _x( 'Separate member types with commas', 'Member type taxonomy separate items with commas label', 'buddypress' ),
+            'add_or_remove_items'        => _x( 'Add or remove member types', 'Member type taxonomy add or remove items label', 'buddypress' ),
+            'choose_from_most_used'      => _x( 'Choose from the most used meber types', 'Member type taxonomy choose from most used label', 'buddypress' ),
+            'not_found'                  => _x( 'No member types found.', 'Member type taxonomy not found label', 'buddypress' ),
+            'no_terms'                   => _x( 'No member types', 'Member type taxonomy no terms label', 'buddypress' ),
+            'items_list_navigation'      => _x( 'Member Types list navigation', 'Member type taxonomy items list navigation label', 'buddypress' ),
+            'items_list'                 => _x( 'Member Types list', 'Member type taxonomy items list label', 'buddypress' ),
+
+            /* translators: Tab heading when selecting from the most used terms. */
+            'most_used'                  => _x( 'Most Used', 'Member type taxonomy most used items label', 'buddypress' ),
+            'back_to_items'              => _x( '← Back to Member Types', 'Member type taxonomy back to items label', 'buddypress' ),
+
             // Specific to BuddyPress.
             'bp_type_id_label'           => _x( 'Member Type ID', 'BP Member type ID label', 'buddypress' ),
@@ -2735 +2743 @@
         array_merge(
             array(
-                'description' => _x( 'BuddyPress Member types', 'Member type taxonomy description', 'buddypress' ),
+                'description' => _x( 'BuddyPress Member Types', 'Member type taxonomy description', 'buddypress' ),
                 'labels'      => array_merge( bp_get_member_type_tax_labels(), bp_get_taxonomy_common_labels() ),
             ),
@@ -2742 +2750 @@
     );
 }
+
+/**
+ * Extend generic Type metadata schema to match Member Type needs.
+ *
+ * @since 7.0.0
+ *
+ * @param array  $schema   The generic Type metadata schema.
+ * @param string $taxonomy The taxonomy name the schema applies to.
+ * @return array           The Member Type metadata schema.
+ */
+function bp_get_member_type_metadata_schema( $schema = array(), $taxonomy = '' ) {
+    if ( bp_get_member_type_tax_name() === $taxonomy ) {
+
+        // Directory
+        if ( isset( $schema['bp_type_has_directory']['description'] ) ) {
+            $schema['bp_type_has_directory']['description'] = __( 'Make a list of members matching this type available on the members directory.', 'buddypress' );
+        }
+
+        // Slug
+        if ( isset( $schema['bp_type_directory_slug']['description'] ) ) {
+            $schema['bp_type_directory_slug']['description'] = __( 'Enter if you want the type slug to be different from its ID.', 'buddypress' );
+        }
+    }
+
+    return $schema;
+}
+add_filter( 'bp_get_type_metadata_schema', 'bp_get_member_type_metadata_schema', 1, 2 );
 
 /**