Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
11/09/2020 02:47:32 AM (13 months ago)
Author:
johnjamesjacoby
Message:

Group/Member Types: More string changes.

This commit includes the following code changes:

  • Change case of strings to match how WordPress core labels are cased
  • Reorder schema so singular is before plural (see: order of adjectives)
  • Adds missing taxonomy labels for core functionalities that could be activated or used later (hierarchy, popularity, etc...)
  • Simplifies all verbiage, to be more concise without sacrificing accuracy or descriptiveness (removes example URLs, encoded quotes, etc...)
  • Remove "member" references from default strings, and re-add them back in using member-specific variants to match how groups works
  • Related inline documentation

Together, these changes bring both Group and Member types closer in readability and usability to other taxonomies, making them feel a little bit more familiar, while also keeping strings within 2 lines tall on most viewport sizes, and hopefully making them easier to understand for users who are new to these features.

See #7179, #7181.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-core/bp-core-functions.php

    r12745 r12776  
    29782978function bp_get_taxonomy_common_labels() {
    29792979    return array(
    2980         'bp_type_name'           => _x( 'Name', 'BP Type name label', 'buddypress' ),
     2980        'bp_type_name'           => _x( 'Plural Name', 'BP Type name label', 'buddypress' ),
    29812981        'bp_type_singular_name'  => _x( 'Singular name', 'BP Type singular name label', 'buddypress' ),
    2982         'bp_type_has_directory'  => _x( 'Add Type-Filtered Directory View', 'BP Type has directory checkbox label', 'buddypress' ),
     2982        'bp_type_has_directory'  => _x( 'Has Directory View', 'BP Type has directory checkbox label', 'buddypress' ),
    29832983        'bp_type_directory_slug' => _x( 'Custom type directory slug', 'BP Type slug label', 'buddypress' ),
    29842984    );
     
    30873087function bp_get_type_metadata_schema( $suppress_filters = false, $type_taxonomy = '' ) {
    30883088    $schema = array(
    3089         'bp_type_name' => array(
    3090             'description'       => __( 'The name of your type, at the plural form.', 'buddypress' ),
     3089        'bp_type_singular_name' => array(
     3090            'description'       => __( 'The name of this type in singular form. ', 'buddypress' ),
    30913091            'type'              => 'string',
    30923092            'single'            => true,
    30933093            'sanitize_callback' => 'sanitize_text_field',
    30943094        ),
    3095         'bp_type_singular_name' => array(
    3096             'description'       => __( 'The name of your type, at the singular form.', 'buddypress' ),
     3095        'bp_type_name' => array(
     3096            'description'       => __( 'The name of this type in plural form.', 'buddypress' ),
    30973097            'type'              => 'string',
    30983098            'single'            => true,
     
    31003100        ),
    31013101        'bp_type_has_directory' => array(
    3102             'description'       => __( 'Add a list of members matching the member type available on the Members Directory page (e.g. site.url/members/type/teacher/).', 'buddypress' ),
     3102            'description'       => __( 'Make a list matching this type available on the directory.', 'buddypress' ),
    31033103            'type'              => 'boolean',
    31043104            'single'            => true,
     
    31063106        ),
    31073107        'bp_type_directory_slug' => array(
    3108             'label'             => __( 'Custom type directory slug', 'buddypress' ),
    3109             'description'       => __( 'If you want to use a slug that is different from the Member Type ID above, enter it here.', 'buddypress' ),
     3108            'label'             => __( 'Type slug', 'buddypress' ),
     3109            'description'       => __( 'Enter if you want the type slug to be different from its ID.', 'buddypress' ),
    31103110            'type'              => 'string',
    31113111            'single'            => true,
Note: See TracChangeset for help on using the changeset viewer.