Changeset 12776 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

11/09/2020 02:47:32 AM (4 years ago)

Author:

johnjamesjacoby

Message:

Group/Member Types: More string changes.

This commit includes the following code changes:

• Change case of strings to match how WordPress core labels are cased
• Reorder schema so singular is before plural (see: order of adjectives)
• Adds missing taxonomy labels for core functionalities that could be activated or used later (hierarchy, popularity, etc...)
• Simplifies all verbiage, to be more concise without sacrificing accuracy or descriptiveness (removes example URLs, encoded quotes, etc...)
• Remove "member" references from default strings, and re-add them back in using member-specific variants to match how groups works
• Related inline documentation

Together, these changes bring both Group and Member types closer in readability and usability to other taxonomies, making them feel a little bit more familiar, while also keeping strings within 2 lines tall on most viewport sizes, and hopefully making them easier to understand for users who are new to these features.

See #7179, #7181.

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (4 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -2978 +2978 @@
 function bp_get_taxonomy_common_labels() {
     return array(
-        'bp_type_name'           => _x( 'Name', 'BP Type name label', 'buddypress' ),
+        'bp_type_name'           => _x( 'Plural Name', 'BP Type name label', 'buddypress' ),
         'bp_type_singular_name'  => _x( 'Singular name', 'BP Type singular name label', 'buddypress' ),
-        'bp_type_has_directory'  => _x( 'Add Type-Filtered Directory View', 'BP Type has directory checkbox label', 'buddypress' ),
+        'bp_type_has_directory'  => _x( 'Has Directory View', 'BP Type has directory checkbox label', 'buddypress' ),
         'bp_type_directory_slug' => _x( 'Custom type directory slug', 'BP Type slug label', 'buddypress' ),
     );
@@ -3087 +3087 @@
 function bp_get_type_metadata_schema( $suppress_filters = false, $type_taxonomy = '' ) {
     $schema = array(
-        'bp_type_name' => array(
-            'description'       => __( 'The name of your type, at the plural form.', 'buddypress' ),
+        'bp_type_singular_name' => array(
+            'description'       => __( 'The name of this type in singular form. ', 'buddypress' ),
             'type'              => 'string',
             'single'            => true,
             'sanitize_callback' => 'sanitize_text_field',
         ),
-        'bp_type_singular_name' => array(
-            'description'       => __( 'The name of your type, at the singular form.', 'buddypress' ),
+        'bp_type_name' => array(
+            'description'       => __( 'The name of this type in plural form.', 'buddypress' ),
             'type'              => 'string',
             'single'            => true,
@@ -3100 +3100 @@
         ),
         'bp_type_has_directory' => array(
-            'description'       => __( 'Add a list of members matching the member type available on the Members Directory page (e.g. site.url/members/type/teacher/).', 'buddypress' ),
+            'description'       => __( 'Make a list matching this type available on the directory.', 'buddypress' ),
             'type'              => 'boolean',
             'single'            => true,
@@ -3106 +3106 @@
         ),
         'bp_type_directory_slug' => array(
-            'label'             => __( 'Custom type directory slug', 'buddypress' ),
-            'description'       => __( 'If you want to use a slug that is different from the Member Type ID above, enter it here.', 'buddypress' ),
+            'label'             => __( 'Type slug', 'buddypress' ),
+            'description'       => __( 'Enter if you want the type slug to be different from its ID.', 'buddypress' ),
             'type'              => 'string',
             'single'            => true,