Changeset 12768 for trunk/src/bp-xprofile/bp-xprofile-functions.php

Timestamp:

10/26/2020 02:11:53 PM (4 years ago)

Author:

boonebgorges

Message:

Declare $get_data = false when calling xprofile_get_field().

The default value of $get_data is true, which means that when calling
xprofile_get_field() with no explicit $user_id, but with a logged-in user,
BP_XProfile_Field::populate() will attempt to fetch the user's data. This
is usually neither intended nor needed, and results in unnecessary database
overhead.

See #8378.

File:

• trunk/src/bp-xprofile/bp-xprofile-functions.php (modified) (3 diffs)

trunk/src/bp-xprofile/bp-xprofile-functions.php

@@ -255 +255 @@
     // Instantiate a new field object.
     if ( ! empty( $r['field_id'] ) ) {
-        $field = xprofile_get_field( $r['field_id'] );
+        $field = xprofile_get_field( $r['field_id'], null, false );
     } else {
         $field = new BP_XProfile_Field;
@@ -526 +526 @@
 
     // Use the user's stored level, unless custom visibility is disabled.
-    $field = xprofile_get_field( $field_id );
+    $field = xprofile_get_field( $field_id, null, false );
     if ( isset( $field->allow_custom_visibility ) && 'disabled' === $field->allow_custom_visibility ) {
         $current_level = $field->default_visibility;
@@ -1100 +1100 @@
     }
 
-    $field = xprofile_get_field( $field_id );
+    $field = xprofile_get_field( $field_id, null, false );
 
     $enabled = false;