Changeset 12768 for trunk/src/bp-xprofile/bp-xprofile-caps.php

Timestamp:

10/26/2020 02:11:53 PM (4 years ago)

Author:

boonebgorges

Message:

Declare $get_data = false when calling xprofile_get_field().

The default value of $get_data is true, which means that when calling
xprofile_get_field() with no explicit $user_id, but with a logged-in user,
BP_XProfile_Field::populate() will attempt to fetch the user's data. This
is usually neither intended nor needed, and results in unnecessary database
overhead.

See #8378.

File:

• trunk/src/bp-xprofile/bp-xprofile-caps.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-caps.php

@@ -86 +86 @@
     if ( 'bp_xprofile_change_field_visibility' === $capability && 0 === $user_id ) {
         $field_id = bp_get_the_profile_field_id();
-        if ( $field_id && $field = xprofile_get_field( $field_id ) ) {
+        if ( $field_id && $field = xprofile_get_field( $field_id, null, false ) ) {
             $user_can = 'allowed' === $field->allow_custom_visibility;
         }