Changeset 12753 for trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

Timestamp:

10/15/2020 04:33:31 PM (4 years ago)

Author:

imath

Message:

Core: use only one global to store the Notifications DB table name

• Deprecate $bp->core->table_name_notifications.
• Add a magic getter to BP_Core, with a fallback if the Notifications component isn't active.
• Audit the related queries and method params, and makes sure they work as intended, and update them to our latest coding standards.

Props johnjamesjacoby

Fixes #8360

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (1 diff)

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -557 +557 @@
      *              false.
      */
-    public static function check_access( $user_id, $notification_id ) {
+    public static function check_access( $user_id = 0, $notification_id = 0 ) {
         global $wpdb;
 
         $bp = buddypress();
 
-        return $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(id) FROM {$bp->core->table_name_notifications} WHERE id = %d AND user_id = %d", $notification_id, $user_id ) );
+        $query   = "SELECT COUNT(id) FROM {$bp->notifications->table_name} WHERE id = %d AND user_id = %d";
+        $prepare = $wpdb->prepare( $query, $notification_id, $user_id );
+        $result  = $wpdb->get_var( $prepare );
+
+        return $result;
     }